Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 12207016: Split CompileCallConstant into logical parts for Frontend and Backend. (Closed)

Created:
7 years, 10 months ago by Toon Verwaest
Modified:
7 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Split CompileCallConstant into logical parts for Frontend and Backend. Initial step towards separating IC (map check(s)), handler frontend (prototype-check) and handler backend (actual handler code). - Still need to split the map-check (IC) from rest of the prototype chain check. - Still need to turn different parts in own code objects and cache them in more optimal places. Committed: https://code.google.com/p/v8/source/detail?r=13604

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -291 lines) Patch
M src/arm/stub-cache-arm.cc View 2 chunks +76 lines, -73 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 3 chunks +74 lines, -72 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 2 chunks +72 lines, -71 lines 0 comments Download
M src/stub-cache.h View 1 chunk +10 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 3 chunks +73 lines, -72 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL
7 years, 10 months ago (2013-02-05 12:21:21 UTC) #1
Jakob Kummerow
7 years, 10 months ago (2013-02-06 10:57:24 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698