Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 12205002: Packaged apps manifest requires 'fullscreen' permission for HTML5 api. (Closed)

Created:
7 years, 10 months ago by scheib
Modified:
7 years, 10 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Aaron Boodman, jeremya+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Packaged apps manifest requires 'fullscreen' permission for HTML5 api. For security precautions, packaged applications that use HTML5 fullscreen api must add 'fullscreen' to the permissions in the manifest. No user visible message is required. BUG=166279 TEST=Manually load app chrome/test/data/extensions/api_test/fullscreen/has_permission, launch, click in window, verify it takes window fullscreen. alt-f4 to exit. Load adjacent no_permission test, launch, click, it won't go fullscreen, right click and inspect element, view developer console, verify the 'fullscreen' permission is suggested. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180791

Patch Set 1 #

Patch Set 2 : Prune back to just apps #

Total comments: 2

Patch Set 3 : PermissionMessage test fix; copyright date #

Patch Set 4 : Removed template params from permission_warnings.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -6 lines) Patch
A chrome/browser/extensions/extension_fullscreen_apitest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/extensions/suggest_permission_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 chunk +10 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/declare_permissions.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/permission_warnings.html View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/fullscreen/has_permission/manifest.json View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/data/extensions/api_test/fullscreen/has_permission/window.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/fullscreen/has_permission/window.js View 1 chunk +13 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/fullscreen/no_permission/background.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/fullscreen/no_permission/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/api_test/fullscreen/no_permission/window.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/api_test/fullscreen/no_permission/window.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
scheib
7 years, 10 months ago (2013-02-04 23:09:36 UTC) #1
scheib
Actually -- hold off -- I'm going to prune this back to just apply to ...
7 years, 10 months ago (2013-02-04 23:15:09 UTC) #2
scheib
Just for apps now.
7 years, 10 months ago (2013-02-04 23:28:55 UTC) #3
miket_OOO
Very nice. LGTM. https://codereview.chromium.org/12205002/diff/4001/chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js File chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js (right): https://codereview.chromium.org/12205002/diff/4001/chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js#newcode7 chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js:7: }); Is this an issue with ...
7 years, 10 months ago (2013-02-04 23:55:42 UTC) #4
scheib
Thanks https://codereview.chromium.org/12205002/diff/4001/chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js File chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js (right): https://codereview.chromium.org/12205002/diff/4001/chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js#newcode7 chrome/test/data/extensions/api_test/fullscreen/has_permission/background.js:7: }); On 2013/02/04 23:55:42, miket wrote: > Is ...
7 years, 10 months ago (2013-02-05 16:59:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/12205002/11001
7 years, 10 months ago (2013-02-05 17:17:51 UTC) #6
commit-bot: I haz the power
Presubmit check for 12205002-11001 failed and returned exit status 1. *----------------------------------* | integration_test.py has failures ...
7 years, 10 months ago (2013-02-05 17:18:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/12205002/11001
7 years, 10 months ago (2013-02-05 18:13:34 UTC) #8
commit-bot: I haz the power
Presubmit check for 12205002-11001 failed and returned exit status 1. *----------------------------------* | integration_test.py has failures ...
7 years, 10 months ago (2013-02-05 18:13:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/12205002/15003
7 years, 10 months ago (2013-02-05 19:28:25 UTC) #10
commit-bot: I haz the power
7 years, 10 months ago (2013-02-05 21:55:22 UTC) #11
Message was sent while issue was closed.
Change committed as 180791

Powered by Google App Engine
This is Rietveld 408576698