Rename funnybase and add more serializations.

Rename funnybase and add more serializations.

This renames funnybase to cmpbin, and adds serialization routines
for string/[]byte and floats.

These will be used as part of the upcoming go GAE SDK interposer
library for the testing database, as well as the memcache caching
serialization implementation.

R=maruel@chromium.org, dnj@chromium.org
BUG=

Committed: https://github.com/luci/luci-go/commit/b85c6dd748361e8244122faac44b5beefcd2db37

[iannucci, 2015-07-02 21:35:19]

Patchset #1 (id:1) has been deleted

[iannucci, 2015-07-02 21:38:51]

Patchset #1 (id:20001) has been deleted

[iannucci, 2015-07-06 22:38:04]

iannucci@chromium.org changed reviewers:
+ vadimsh@chromium.org

[iannucci, 2015-07-06 22:38:04]

post-weekend ping :)

[M-A Ruel, 2015-07-06 23:21:35]

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/co...
File common/cmpbin/common_test.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/co...
common/cmpbin/common_test.go:19: fmt.Println("cmpbin.seed =", *seed)
Please remove

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/do...
File common/cmpbin/doc.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/do...
common/cmpbin/doc.go:25: //   * given an 2's compliment value V
I prefer - to * for lists (not a big deal, since it's not markdown anyway).

In fact, I'm not sure this will render well (?)

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/st...
File common/cmpbin/string.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/st...
common/cmpbin/string.go:16: // set to allow 2MB of user data (taking encoding
size increase into account).
s/increase/overhead/

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/st...
common/cmpbin/string.go:72: tmpBuf := &bytes.Buffer{}
It doesn't need to be in heap, so use:
tmpBuf := bytes.Buffer{}

[iannucci, 2015-07-07 00:03:27]

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/co...
File common/cmpbin/common_test.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/co...
common/cmpbin/common_test.go:19: fmt.Println("cmpbin.seed =", *seed)
On 2015/07/06 23:21:34, M-A Ruel wrote:
> Please remove

This is to enable randomized test failures to be reproducible (i.e. if a
randomized test fails, you can easily reproduce it by copy-pasting this seed
value back onto the command line).

That said, the flag should be cmpbin.seed to match.

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/do...
File common/cmpbin/doc.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/do...
common/cmpbin/doc.go:25: //   * given an 2's compliment value V
On 2015/07/06 23:21:35, M-A Ruel wrote:
> I prefer - to * for lists (not a big deal, since it's not markdown anyway).
> 
> In fact, I'm not sure this will render well (?)

It's considered an indented block (so it's <pre>...</pre>). It currently looks
good in both plaintext and html. I'll switch to - though.

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/st...
File common/cmpbin/string.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/st...
common/cmpbin/string.go:16: // set to allow 2MB of user data (taking encoding
size increase into account).
On 2015/07/06 23:21:35, M-A Ruel wrote:
> s/increase/overhead/

Done.

https://chromiumcodereview.appspot.com/1219323002/diff/60001/common/cmpbin/st...
common/cmpbin/string.go:72: tmpBuf := &bytes.Buffer{}
On 2015/07/06 23:21:35, M-A Ruel wrote:
> It doesn't need to be in heap, so use:
> tmpBuf := bytes.Buffer{}

Done.

[M-A Ruel, 2015-07-07 16:41:40]

lgtm

https://chromiumcodereview.appspot.com/1219323002/diff/80001/common/cmpbin/co...
File common/cmpbin/common_test.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/80001/common/cmpbin/co...
common/cmpbin/common_test.go:19: fmt.Println("cmpbin.seed =", *seed)
I'd prefer log instead of fmt.

https://chromiumcodereview.appspot.com/1219323002/diff/80001/common/cmpbin/st...
File common/cmpbin/string.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/80001/common/cmpbin/st...
common/cmpbin/string.go:25: func WriteString(buf io.ByteWriter, s string) (n
int, err error) {
please don't use named arguments unless really useful, IMHO it makes the cde
harder to scan.

[iannucci, 2015-07-07 18:37:37]

thanks for the review :)

https://chromiumcodereview.appspot.com/1219323002/diff/80001/common/cmpbin/co...
File common/cmpbin/common_test.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/80001/common/cmpbin/co...
common/cmpbin/common_test.go:19: fmt.Println("cmpbin.seed =", *seed)
On 2015/07/07 16:41:40, M-A Ruel wrote:
> I'd prefer log instead of fmt.

Done.

https://chromiumcodereview.appspot.com/1219323002/diff/80001/common/cmpbin/st...
File common/cmpbin/string.go (right):

https://chromiumcodereview.appspot.com/1219323002/diff/80001/common/cmpbin/st...
common/cmpbin/string.go:25: func WriteString(buf io.ByteWriter, s string) (n
int, err error) {
On 2015/07/07 16:41:40, M-A Ruel wrote:
> please don't use named arguments unless really useful, IMHO it makes the cde
> harder to scan.

I think you meant named return values? I copied this function signature style
from http://golang.org/pkg/io/#Reader .

Anyhow tweaked these signatures and the docstrings.

[iannucci, 2015-07-07 18:38:24]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-07-07 18:38:25]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1219323002/#ps100001 (title: "fixes")

[commit-bot: I haz the power, 2015-07-07 18:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 18:43:03]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[iannucci, 2015-07-07 19:29:31]

Patchset #5 (id:120001) has been deleted

[iannucci, 2015-07-07 19:31:03]

Committed patchset #4 (id:100001) manually as
b85c6dd748361e8244122faac44b5beefcd2db37 (presubmit successful).