Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: ppapi/tests/test_broker.cc

Issue 12193015: PPAPI/NaCl: Make related tests run in 1 fixture (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ppapi/ppapi_test.cc ('k') | ppapi/tests/test_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/test_broker.cc
diff --git a/ppapi/tests/test_broker.cc b/ppapi/tests/test_broker.cc
index d66e9dd73990ab4883338de30d22c6762d531b52..0537b953a29abd47a560bba602e80b5ae3f7f4d2 100644
--- a/ppapi/tests/test_broker.cc
+++ b/ppapi/tests/test_broker.cc
@@ -217,13 +217,12 @@ void TestBroker::RunTests(const std::string& filter) {
// The following tests require special setup, so only run them if they're
// explicitly specified by the filter.
- if (filter.empty())
- return;
-
- RUN_TEST(ConnectPermissionDenied, filter);
- RUN_TEST(ConnectPermissionGranted, filter);
- RUN_TEST(IsAllowedPermissionDenied, filter);
- RUN_TEST(IsAllowedPermissionGranted, filter);
+ if (!ShouldRunAllTests(filter)) {
+ RUN_TEST(ConnectPermissionDenied, filter);
+ RUN_TEST(ConnectPermissionGranted, filter);
+ RUN_TEST(IsAllowedPermissionDenied, filter);
+ RUN_TEST(IsAllowedPermissionGranted, filter);
+ }
}
std::string TestBroker::TestCreate() {
« no previous file with comments | « chrome/test/ppapi/ppapi_test.cc ('k') | ppapi/tests/test_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698