Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased view_messages.h and fixed the link issue on the linux bot Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 2332 matching lines...) Expand 10 before | Expand all | Expand 10 after
2343 2343
2344 #if defined(OS_ANDROID) 2344 #if defined(OS_ANDROID)
2345 void WebContentsImpl::OnFindMatchRectsReply( 2345 void WebContentsImpl::OnFindMatchRectsReply(
2346 int version, 2346 int version,
2347 const std::vector<gfx::RectF>& rects, 2347 const std::vector<gfx::RectF>& rects,
2348 const gfx::RectF& active_rect) { 2348 const gfx::RectF& active_rect) {
2349 if (delegate_) 2349 if (delegate_)
2350 delegate_->FindMatchRectsReply(this, version, rects, active_rect); 2350 delegate_->FindMatchRectsReply(this, version, rects, active_rect);
2351 } 2351 }
2352 2352
2353 void WebContentsImpl::OnOpenDateTimeDialog(int type, const std::string& value) { 2353 void WebContentsImpl::OnOpenDateTimeDialog(
2354 const ViewHostMsg_DateTimeDialogValue_Params& value) {
2354 date_time_chooser_->ShowDialog( 2355 date_time_chooser_->ShowDialog(
2355 GetContentNativeView(), GetRenderViewHost(), type, value); 2356 GetContentNativeView(), GetRenderViewHost(), value.dialog_type,
2357 value.year, value.month, value.day, value.hour,
2358 value.minute, value.second);
2356 } 2359 }
2357 2360
2358 #endif 2361 #endif
2359 2362
2360 void WebContentsImpl::OnCrashedPlugin(const FilePath& plugin_path, 2363 void WebContentsImpl::OnCrashedPlugin(const FilePath& plugin_path,
2361 base::ProcessId plugin_pid) { 2364 base::ProcessId plugin_pid) {
2362 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2365 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2363 PluginCrashed(plugin_path, plugin_pid)); 2366 PluginCrashed(plugin_path, plugin_pid));
2364 } 2367 }
2365 2368
(...skipping 1126 matching lines...) Expand 10 before | Expand all | Expand 10 after
3492 3495
3493 BrowserPluginGuest* WebContentsImpl::GetBrowserPluginGuest() const { 3496 BrowserPluginGuest* WebContentsImpl::GetBrowserPluginGuest() const {
3494 return browser_plugin_guest_.get(); 3497 return browser_plugin_guest_.get();
3495 } 3498 }
3496 3499
3497 BrowserPluginEmbedder* WebContentsImpl::GetBrowserPluginEmbedder() const { 3500 BrowserPluginEmbedder* WebContentsImpl::GetBrowserPluginEmbedder() const {
3498 return browser_plugin_embedder_.get(); 3501 return browser_plugin_embedder_.get();
3499 } 3502 }
3500 3503
3501 } // namespace content 3504 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698