Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: chrome/common/extensions/permissions/permission_set.cc

Issue 12189018: <webview>: Implement WebRequest API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Diff from latest patch Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set.cc
diff --git a/chrome/common/extensions/permissions/permission_set.cc b/chrome/common/extensions/permissions/permission_set.cc
index 0f572ee5c38638f48bce2d29339a5558021ddf39..74532bdd00bf47c08e013daa8f386adb35917b9f 100644
--- a/chrome/common/extensions/permissions/permission_set.cc
+++ b/chrome/common/extensions/permissions/permission_set.cc
@@ -521,6 +521,11 @@ std::set<std::string> PermissionSet::GetDistinctHosts(
}
void PermissionSet::InitImplicitPermissions() {
+ // TODO(fsamuel): Is there a better way to request access to the WebRequest
+ // API without exposing it to the Chrome App?
+ if (apis_.find(APIPermission::kWebView) != apis_.end())
+ apis_.insert(APIPermission::kWebRequestInternal);
+
// The webRequest permission implies the internal version as well.
if (apis_.find(APIPermission::kWebRequest) != apis_.end())
apis_.insert(APIPermission::kWebRequestInternal);

Powered by Google App Engine
This is Rietveld 408576698