chrome/browser/ui/autofill/autofill_popup_controller_impl.h - Issue 12188020: Adding the page and DPI scale adjustment for Autofill Popups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

Issue 12188020: Adding the page and DPI scale adjustment for Autofill Popups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing Autofill unittests Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_popup_controller.h ('K') | « chrome/browser/ui/autofill/autofill_popup_controller.h ('k') | chrome/browser/ui/autofill/autofill_popup_controller_impl.cc » ('j') | chrome/browser/ui/autofill/autofill_popup_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.h

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h

index d0ab107e7bbff6a4958398c57ffb04b117b2ac2e..0eeced88a2c97995558e6c539bf6366601d10cd2 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.h

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.h

@@ -11,6 +11,7 @@

#include "content/public/browser/keyboard_listener.h"

#include "ui/gfx/font.h"

#include "ui/gfx/rect.h"

+#include "ui/gfx/rect_f.h"

class AutofillPopupDelegate;

class AutofillPopupView;

@@ -36,7 +37,7 @@ class AutofillPopupControllerImpl : public AutofillPopupController,

AutofillPopupControllerImpl* previous,

AutofillPopupDelegate* delegate,

gfx::NativeView container_view,

- const gfx::Rect& element_bounds);

+ const gfx::RectF& element_bounds);

// Shows the popup, or updates the existing popup with the given values.

void Show(const std::vector<string16>& names,

@@ -58,7 +59,7 @@ class AutofillPopupControllerImpl : public AutofillPopupController,

AutofillPopupControllerImpl(AutofillPopupDelegate* delegate,

gfx::NativeView container_view,

- const gfx::Rect& element_bounds);

+ const gfx::RectF& element_bounds);

virtual ~AutofillPopupControllerImpl();

// AutofillPopupController implementation.

@@ -74,7 +75,8 @@ class AutofillPopupControllerImpl : public AutofillPopupController,

virtual void SetPopupBounds(const gfx::Rect& bounds) OVERRIDE;

virtual const gfx::Rect& popup_bounds() const OVERRIDE;

virtual gfx::NativeView container_view() const OVERRIDE;

- virtual const gfx::Rect& element_bounds() const OVERRIDE;

+ virtual const gfx::RectF& element_bounds() const OVERRIDE;

+ virtual const gfx::Rect rounded_element_bounds() const OVERRIDE;

virtual const std::vector<string16>& names() const OVERRIDE;

virtual const std::vector<string16>& subtexts() const OVERRIDE;

virtual const std::vector<string16>& icons() const OVERRIDE;

@@ -172,7 +174,7 @@ class AutofillPopupControllerImpl : public AutofillPopupController,

// The bounds of the text element that is the focus of the Autofill.

// These coordinates are in screen space.

- const gfx::Rect element_bounds_;

+ const gfx::RectF element_bounds_;

// The bounds of the Autofill popup.

gfx::Rect popup_bounds_;