Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: chrome/browser/autofill/autofill_external_delegate.cc

Issue 12188020: Adding the page and DPI scale adjustment for Autofill Popups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing Autofill unittests Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_external_delegate.cc
diff --git a/chrome/browser/autofill/autofill_external_delegate.cc b/chrome/browser/autofill/autofill_external_delegate.cc
index 501f8ec9269fc9fe5647d79ed43198addbd2cb8d..27d2300a77b34949cad7fa82172bb7469d471fd6 100644
--- a/chrome/browser/autofill/autofill_external_delegate.cc
+++ b/chrome/browser/autofill/autofill_external_delegate.cc
@@ -71,7 +71,7 @@ AutofillExternalDelegate::~AutofillExternalDelegate() {
void AutofillExternalDelegate::OnQuery(int query_id,
const FormData& form,
const FormFieldData& field,
- const gfx::Rect& element_bounds,
+ const gfx::RectF& element_bounds,
bool display_warning_if_disabled) {
autofill_query_form_ = form;
autofill_query_field_ = field;
@@ -147,7 +147,7 @@ void AutofillExternalDelegate::OnSuggestionsReturned(
void AutofillExternalDelegate::OnShowPasswordSuggestions(
const std::vector<string16>& suggestions,
const FormFieldData& field,
- const gfx::Rect& element_bounds) {
+ const gfx::RectF& element_bounds) {
autofill_query_field_ = field;
EnsurePopupForElement(element_bounds);
@@ -163,11 +163,11 @@ void AutofillExternalDelegate::OnShowPasswordSuggestions(
}
void AutofillExternalDelegate::EnsurePopupForElement(
- const gfx::Rect& element_bounds) {
+ const gfx::RectF& element_bounds) {
// Convert element_bounds to be in screen space. If |web_contents_| is NULL
// then assume the element_bounds is already in screen space (since we don't
// have any other way of converting to screen space).
- gfx::Rect element_bounds_in_screen_space = element_bounds;
+ gfx::RectF element_bounds_in_screen_space = element_bounds;
if (web_contents_) {
gfx::Rect client_area;
web_contents_->GetContainerBounds(&client_area);

Powered by Google App Engine
This is Rietveld 408576698