Adding the page and DPI scale adjustment for Autofill Popups.

chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/test_autofill_external_delegate.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 58 matching lines @@
   }
   bool RemoveSelectedLine() {
     return AutofillPopupControllerImpl::RemoveSelectedLine();
   }
   void DoHide() {
     AutofillPopupControllerImpl::Hide();
   }
   const gfx::Rect& popup_bounds() const {
     return AutofillPopupControllerImpl::popup_bounds();
   }
-  const gfx::Rect& element_bounds() const {
-    return AutofillPopupControllerImpl::element_bounds();
+  const gfx::Rect rounded_element_bounds() const {
+    return AutofillPopupControllerImpl::rounded_element_bounds();
   }
 #if !defined(OS_ANDROID)
   const gfx::Font& name_font() const {
     return AutofillPopupControllerImpl::name_font();
   }
   const gfx::Font& subtext_font() const {
     return AutofillPopupControllerImpl::subtext_font();
   }
 #endif
   int GetDesiredPopupWidth() const {
@@ skipping 182 matching lines @@
           NULL,
           gfx::Rect());
   EXPECT_EQ(controller, controller2);
   controller->Hide();
 
   testing::NiceMock<TestAutofillPopupController>* test_controller =
       new testing::NiceMock<TestAutofillPopupController>(&delegate,
                                                          gfx::Rect());
   EXPECT_CALL(*test_controller, Hide());
 
   gfx::Rect bounds(0, 0, 1, 2);

[Ilya Sherman, 2013/02/05 02:27:53]

This should be a gfx::RectF, right?

[aurimas (slooooooooow), 2013/02/06 00:05:27]

I only changed for element_bounds to use RectF. Popup still uses Rect as popups
can only really be displayed in whole pixel coordinates.

[Ilya Sherman, 2013/02/06 00:07:40]

These bounds *are* element bounds, and you updated GetOrCreate() to take in a
RectF.  What am I missing?

   AutofillPopupControllerImpl* controller3 =
       AutofillPopupControllerImpl::GetOrCreate(
           test_controller,
           &delegate,
           NULL,
           bounds);
   EXPECT_EQ(
       bounds,
-      static_cast<AutofillPopupController*>(controller3)->element_bounds());
+      static_cast<AutofillPopupController*>(controller3)->rounded_element_bounds());
   controller3->Hide();
 
   EXPECT_CALL(delegate, ControllerDestroyed());
   delete test_controller;
 }
 
 #if !defined(OS_ANDROID)
 TEST_F(AutofillPopupControllerUnitTest, ElideText) {
   std::vector<string16> names;
   names.push_back(ASCIIToUTF16("Text that will need to be trimmed"));
@@ skipping 82 matching lines @@
     TestAutofillPopupController autofill_popup_controller(&external_delegate_,
                                                           element_bounds[i]);
     autofill_popup_controller.set_display(display);
     autofill_popup_controller.Show(names, names, names, autofill_ids);
 
     EXPECT_EQ(expected_popup_bounds[i].ToString(),
               autofill_popup_controller.popup_bounds().ToString()) <<
         "Popup bounds failed to match for test " << i;
   }
 }