Issue 12188016: Allow BrowserTestBase to do wait.

Issue 12188016: Allow BrowserTestBase to do wait. (Closed)

Created:
7 years, 10 months ago by nilesh

Modified:
7 years, 10 months ago

Reviewers:
Jay Civelli, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow BrowserTestBase to do wait. On Android, RemoteTestServer destructions waits on the caller thread. Also not setting the contentview in test activity to avoid onAttachedToWindow and onShow calls. BUG=138275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180541

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -4 lines)			Patch
M	base/threading/thread_restrictions.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/public/test/browser_test_base.cc	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
M	content/shell/android/browsertests_apk/res/layout/test_activity.xml	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12188016/1005

7 years, 10 months ago (2013-02-04 17:38:13 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=107782

7 years, 10 months ago (2013-02-04 18:51:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/12188016/1005

7 years, 10 months ago (2013-02-04 19:43:17 UTC) #6

Message was sent while issue was closed.

Change committed as 180541

Expand Messages | Collapse Messages