Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 12186012: Merged r13471, r13504 into 3.15 branch. (Closed)

Created:
7 years, 10 months ago by Yang
Modified:
7 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Merged r13471, r13504 into 3.15 branch. Correctly reset lastIndex in an RegExp object. Fix additional spec violations wrt RegExp.lastIndex. BUG=170856, v8:2437 R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -27 lines) Patch
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/runtime.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M src/string.js View 3 chunks +17 lines, -4 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2437.js View 2 chunks +81 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-170856.js View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
7 years, 10 months ago (2013-02-04 10:13:18 UTC) #1
Sven Panne
7 years, 10 months ago (2013-02-04 10:14:55 UTC) #2
LGTM (rubberstamp)

Powered by Google App Engine
This is Rietveld 408576698