cc: Disable partial updates when impl-side painting is used.

cc: Disable partial updates when impl-side painting is used.

This prevents us from updating textures currently in use by active
tree before tree activation.

BUG=173886
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182218

[reveman, 2013-02-03 03:47:44]

This is not urgent but I figured I might as well get this done so we don't
forget about it.

[danakj, 2013-02-03 18:24:15]

https://codereview.chromium.org/12185008/diff/1/cc/layer_tree_host.cc
File cc/layer_tree_host.cc (right):

https://codereview.chromium.org/12185008/diff/1/cc/layer_tree_host.cc#newcode161
cc/layer_tree_host.cc:161: maxPartialTextureUpdates =
std::min(m_settings.maxPartialTextureUpdates,
m_proxy->maxPartialTextureUpdates());
Would it be better to have the embedder set maxPartialTextureUpdates to 0
instead, and just (D)CHECK this somewhere in our initialization code when
implSidePainting is on?

[nduca, 2013-02-04 23:20:06]

I dont think that makes sense. I think the way david did it is correct.

[nduca, 2013-02-04 23:20:40]

(Otherwise, its encoding nonorthogonal "if this variable is true, this variable
must be zeor" into the settings struct, which is itself odd)

[danakj, 2013-02-04 23:35:52]

On 2013/02/04 23:20:40, nduca wrote:
> (Otherwise, its encoding nonorthogonal "if this variable is true, this
variable
> must be zeor" into the settings struct, which is itself odd)

Ok, I thought maybe a code assertion that things that should be set together
might help. Whatever you think is best sounds good.

[enne (OOO), 2013-02-11 20:01:57]

lgtm

https://codereview.chromium.org/12185008/diff/1/cc/layer_tree_host.cc
File cc/layer_tree_host.cc (right):

https://codereview.chromium.org/12185008/diff/1/cc/layer_tree_host.cc#newcode161
cc/layer_tree_host.cc:161: maxPartialTextureUpdates =
std::min(m_settings.maxPartialTextureUpdates,
m_proxy->maxPartialTextureUpdates());
On 2013/02/03 18:24:15, danakj wrote:
> Would it be better to have the embedder set maxPartialTextureUpdates to 0
> instead, and just (D)CHECK this somewhere in our initialization code when
> implSidePainting is on?

I disagree; the caller is specifying a maximum, not a specific number.

In a number of cases the LTH uses less than the maximum, so adding a new case
where this happens seems quite reasonable.

[commit-bot: I haz the power, 2013-02-11 20:24:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/12185008/1

[commit-bot: I haz the power, 2013-02-11 21:19:20]

Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[nduca, 2013-02-13 09:28:44]

Did this not land? Does it need to land?

[reveman, 2013-02-13 09:34:35]

On 2013/02/13 09:28:44, nduca wrote:
> Did this not land? Does it need to land?

forgot about this one. it's not critical until impl-side painting is used on
desktop but I should still get this landed.

[commit-bot: I haz the power, 2013-02-13 09:36:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/12185008/1

[commit-bot: I haz the power, 2013-02-13 15:18:20]

Change committed as 182218