Issue 12184015: Inline some regexp code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12184015: Inline some regexp code. (Closed)

Created:
7 years, 10 months ago by Yang

Modified:
7 years, 10 months ago

Reviewers:
Sven Panne, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Inline some regexp code. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13606

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -66 lines)			Patch
M	src/jsregexp.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/jsregexp.cc	View	1	2 chunks	+1 line, -62 lines	0 comments	Download
A	src/jsregexp-inl.h	View	1	1 chunk	+106 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

Quick DBC: Use INLINE instead of inline, the latter does not guarantee any inlining.

7 years, 10 months ago (2013-02-04 14:59:26 UTC) #2

Yang

7 years, 10 months ago (2013-02-06 12:57:24 UTC) #5

On 2013/02/05 09:33:53, ulan wrote:
> LGTM from chromium account.

I ran some tests and decided to not inline SetLastMatchInfo. I added the INLINE
macro to the rest of the functions I wanted to inline.

Expand Messages | Collapse Messages