|
|
Created:
7 years, 10 months ago by dconnelly Modified:
7 years, 10 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionDefine strings for enterprise account sign-in profile link confirmation.
BUG=171236
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181018
Patch Set 1 #Patch Set 2 : Add dialog titles #
Total comments: 6
Patch Set 3 : Update string description #Patch Set 4 : Move dialog title to generated_resources.grd #Patch Set 5 : Update warning message product names per feedback #Patch Set 6 : Move product name strings back out of generated_resources #Patch Set 7 : rebase #
Messages
Total messages: 22 (0 generated)
https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... chrome/app/generated_resources.grd:11264: + <message name="IDS_ENTERPRISE_SIGNIN_PROFILE_LINK_MESSAGE" desc="The warning message displayed to an enterprise user about to link their profile to their Google account"> Note in the description that this message is followed by a "Learn More" link (see IDS_PEPPER_BROKER_MESSAGE for an example). https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... chrome/app/generated_resources.grd:11265: + You are signing in with a managed account and giving its administrator control over your <ph name="PRODUCT_NAME">$1<ex>Chrome</ex></ph> profile. Your <ph name="PRODUCT_NAME">$1<ex>Chrome</ex></ph> data, such as your apps, bookmarks, history, passwords, and other settings will become permanently tied to <ph name="USER_NAME">$1<ex>pat@example.com</ex></ph>. You will be able to delete this data via the Google Accounts Dashboard, but you will not be able to associate this data with another account. I want to confirm that we should use "Chrome" and not "Google Chrome" so I sent off an email about this. Also, note if you do want to use "Chrome", then you should use <ph name="SHORT_PRODUCT_NAME"> -- name="PRODUCT_NAME" is only for the string "Google Chrome". https://codereview.chromium.org/12184012/diff/2001/chrome/app/google_chrome_s... File chrome/app/google_chrome_strings.grd (right): https://codereview.chromium.org/12184012/diff/2001/chrome/app/google_chrome_s... chrome/app/google_chrome_strings.grd:773: Link your Chrome profile So we use placeholders on the previous page for "Chrome" but for the title we're using separate product-specific strings. I'm not sure which is correct (or if it matters) - I sent an email to chromium-dev to clarify this. In any case, I think this is fine as-is, but we'll see what chromium-dev has to say on the matter.
https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... chrome/app/generated_resources.grd:11264: + <message name="IDS_ENTERPRISE_SIGNIN_PROFILE_LINK_MESSAGE" desc="The warning message displayed to an enterprise user about to link their profile to their Google account"> On 2013/02/04 13:53:12, Andrew T Wilson wrote: > Note in the description that this message is followed by a "Learn More" link > (see IDS_PEPPER_BROKER_MESSAGE for an example). Done. https://codereview.chromium.org/12184012/diff/2001/chrome/app/google_chrome_s... File chrome/app/google_chrome_strings.grd (right): https://codereview.chromium.org/12184012/diff/2001/chrome/app/google_chrome_s... chrome/app/google_chrome_strings.grd:773: Link your Chrome profile On 2013/02/04 13:53:12, Andrew T Wilson wrote: > So we use placeholders on the previous page for "Chrome" but for the title we're > using separate product-specific strings. I'm not sure which is correct (or if it > matters) - I sent an email to chromium-dev to clarify this. > > In any case, I think this is fine as-is, but we'll see what chromium-dev has to > say on the matter. I tried to copy the one-click signin notification CL--they put the messages in this file (which will be localized) but the dialog titles in the product-specific files (which will NOT be localized).
Yeah, ironically roger (the author of that CL) just replied to the thread saying that's the wrong way to do it :-P
On 2013/02/04 14:00:17, dconnelly wrote: > https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... > chrome/app/generated_resources.grd:11264: + <message > name="IDS_ENTERPRISE_SIGNIN_PROFILE_LINK_MESSAGE" desc="The warning message > displayed to an enterprise user about to link their profile to their Google > account"> > On 2013/02/04 13:53:12, Andrew T Wilson wrote: > > Note in the description that this message is followed by a "Learn More" link > > (see IDS_PEPPER_BROKER_MESSAGE for an example). > > Done. > > https://codereview.chromium.org/12184012/diff/2001/chrome/app/google_chrome_s... > File chrome/app/google_chrome_strings.grd (right): > > https://codereview.chromium.org/12184012/diff/2001/chrome/app/google_chrome_s... > chrome/app/google_chrome_strings.grd:773: Link your Chrome profile > On 2013/02/04 13:53:12, Andrew T Wilson wrote: > > So we use placeholders on the previous page for "Chrome" but for the title > we're > > using separate product-specific strings. I'm not sure which is correct (or if > it > > matters) - I sent an email to chromium-dev to clarify this. > > > > In any case, I think this is fine as-is, but we'll see what chromium-dev has > to > > say on the matter. > > I tried to copy the one-click signin notification CL--they put the messages in > this file (which will be localized) but the dialog titles in the > product-specific files (which will NOT be localized). Sorry, bad pronoun "this". They put the messages in the "generated_resources" file and the dialog titles in "google_chrome_strings"/"chromium_strings"
... alright, I'll fix it On Mon, Feb 4, 2013 at 3:01 PM, <atwilson@chromium.org> wrote: > Yeah, ironically roger (the author of that CL) just replied to the thread > saying > that's the wrong way to do it :-P > > https://codereview.chromium.org/12184012/
BTW, the stuff in chromium_strings.grd and google_chrome_strings.grd are also localized. The main difference between those files and "generated_resources.grd" is that generated_resources.grd contains strings that are identical across all products.
Okay. The header in chromium_strings says: "<!-- This file contains definitions of strings that are distribution specific. These strings will not be translated and only english versions will be available for now. -->" On Mon, Feb 4, 2013 at 3:06 PM, <atwilson@chromium.org> wrote: > BTW, the stuff in chromium_strings.grd and google_chrome_strings.grd are > also > localized. The main difference between those files and > "generated_resources.grd" > is that generated_resources.grd contains strings that are identical across > all > products. > > > https://codereview.chromium.org/12184012/
Also moved the dialog title to generated_resources.grd https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... chrome/app/generated_resources.grd:11265: + You are signing in with a managed account and giving its administrator control over your <ph name="PRODUCT_NAME">$1<ex>Chrome</ex></ph> profile. Your <ph name="PRODUCT_NAME">$1<ex>Chrome</ex></ph> data, such as your apps, bookmarks, history, passwords, and other settings will become permanently tied to <ph name="USER_NAME">$1<ex>pat@example.com</ex></ph>. You will be able to delete this data via the Google Accounts Dashboard, but you will not be able to associate this data with another account. On 2013/02/04 13:53:12, Andrew T Wilson wrote: > I want to confirm that we should use "Chrome" and not "Google Chrome" so I sent > off an email about this. > > Also, note if you do want to use "Chrome", then you should use <ph > name="SHORT_PRODUCT_NAME"> -- name="PRODUCT_NAME" is only for the string "Google > Chrome". Done.
On 2013/02/04 15:07:27, dconnelly wrote: > Also moved the dialog title to generated_resources.grd > > https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resou... > chrome/app/generated_resources.grd:11265: + You are signing in with a managed > account and giving its administrator control over your <ph > name="PRODUCT_NAME">$1<ex>Chrome</ex></ph> profile. Your <ph > name="PRODUCT_NAME">$1<ex>Chrome</ex></ph> data, such as your apps, bookmarks, > history, passwords, and other settings will become permanently tied to <ph > name="USER_NAME">$1<ex>pat@example.com</ex></ph>. You will be able to delete > this data via the Google Accounts Dashboard, but you will not be able to > associate this data with another account. > On 2013/02/04 13:53:12, Andrew T Wilson wrote: > > I want to confirm that we should use "Chrome" and not "Google Chrome" so I > sent > > off an email about this. > > > > Also, note if you do want to use "Chrome", then you should use <ph > > name="SHORT_PRODUCT_NAME"> -- name="PRODUCT_NAME" is only for the string > "Google > > Chrome". > > Done. updated to use "Google Chrome" the first mention
lgtm please add screenshot to the bug.
On 2013/02/04 23:02:00, cpu wrote: > lgtm > > please add screenshot to the bug. Don't land this yet :) We need to move the bugs containing PRODUCT_NAME placeholders out of generated_resources.grd and into chromium_strings.grd/google_chrome_strings.grd per https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-d...
On 2013/02/05 07:29:47, Andrew T Wilson wrote: > On 2013/02/04 23:02:00, cpu wrote: > > lgtm > > > > please add screenshot to the bug. > > Don't land this yet :) > > We need to move the bugs containing PRODUCT_NAME placeholders out of > generated_resources.grd and into chromium_strings.grd/google_chrome_strings.grd > per > https://groups.google.com/a/chromium.org/forum/?fromgroups=#%21topic/chromium... Done
On 2013/02/04 23:02:00, cpu wrote: > lgtm > > please add screenshot to the bug. We don't have the UI built yet. Can I attach a screenshot after I have it working?
lgtm
ok
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12184012/17004
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12184012/17004
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12184012/17004
Retried try job too often on mac_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12184012/17004
Message was sent while issue was closed.
Change committed as 181018 |