Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Issue 12184012: Define strings for enterprise account sign-in profile link confirmation. (Closed)

Created:
7 years, 10 months ago by dconnelly
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Define strings for enterprise account sign-in profile link confirmation. BUG=171236 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181018

Patch Set 1 #

Patch Set 2 : Add dialog titles #

Total comments: 6

Patch Set 3 : Update string description #

Patch Set 4 : Move dialog title to generated_resources.grd #

Patch Set 5 : Update warning message product names per feedback #

Patch Set 6 : Move product name strings back out of generated_resources #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 3 4 5 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
dconnelly
7 years, 10 months ago (2013-02-04 13:20:04 UTC) #1
Andrew T Wilson (Slow)
https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resources.grd#newcode11264 chrome/app/generated_resources.grd:11264: + <message name="IDS_ENTERPRISE_SIGNIN_PROFILE_LINK_MESSAGE" desc="The warning message displayed to an ...
7 years, 10 months ago (2013-02-04 13:53:12 UTC) #2
dconnelly
https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resources.grd#newcode11264 chrome/app/generated_resources.grd:11264: + <message name="IDS_ENTERPRISE_SIGNIN_PROFILE_LINK_MESSAGE" desc="The warning message displayed to an ...
7 years, 10 months ago (2013-02-04 14:00:17 UTC) #3
Andrew T Wilson (Slow)
Yeah, ironically roger (the author of that CL) just replied to the thread saying that's ...
7 years, 10 months ago (2013-02-04 14:01:28 UTC) #4
dconnelly
On 2013/02/04 14:00:17, dconnelly wrote: > https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resources.grd#newcode11264 > ...
7 years, 10 months ago (2013-02-04 14:02:04 UTC) #5
dconnelly1
... alright, I'll fix it On Mon, Feb 4, 2013 at 3:01 PM, <atwilson@chromium.org> wrote: ...
7 years, 10 months ago (2013-02-04 14:02:52 UTC) #6
Andrew T Wilson (Slow)
BTW, the stuff in chromium_strings.grd and google_chrome_strings.grd are also localized. The main difference between those ...
7 years, 10 months ago (2013-02-04 14:06:05 UTC) #7
dconnelly1
Okay. The header in chromium_strings says: "<!-- This file contains definitions of strings that are ...
7 years, 10 months ago (2013-02-04 14:08:25 UTC) #8
dconnelly
Also moved the dialog title to generated_resources.grd https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/12184012/diff/2001/chrome/app/generated_resources.grd#newcode11265 chrome/app/generated_resources.grd:11265: + You ...
7 years, 10 months ago (2013-02-04 15:07:27 UTC) #9
dconnelly
On 2013/02/04 15:07:27, dconnelly wrote: > Also moved the dialog title to generated_resources.grd > > ...
7 years, 10 months ago (2013-02-04 16:50:32 UTC) #10
cpu_(ooo_6.6-7.5)
lgtm please add screenshot to the bug.
7 years, 10 months ago (2013-02-04 23:02:00 UTC) #11
Andrew T Wilson (Slow)
On 2013/02/04 23:02:00, cpu wrote: > lgtm > > please add screenshot to the bug. ...
7 years, 10 months ago (2013-02-05 07:29:47 UTC) #12
dconnelly
On 2013/02/05 07:29:47, Andrew T Wilson wrote: > On 2013/02/04 23:02:00, cpu wrote: > > ...
7 years, 10 months ago (2013-02-05 08:33:30 UTC) #13
dconnelly
On 2013/02/04 23:02:00, cpu wrote: > lgtm > > please add screenshot to the bug. ...
7 years, 10 months ago (2013-02-05 08:34:24 UTC) #14
Andrew T Wilson (Slow)
lgtm
7 years, 10 months ago (2013-02-05 09:23:45 UTC) #15
cpu_(ooo_6.6-7.5)
ok
7 years, 10 months ago (2013-02-05 21:10:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12184012/17004
7 years, 10 months ago (2013-02-06 14:56:19 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12184012/17004
7 years, 10 months ago (2013-02-06 15:45:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12184012/17004
7 years, 10 months ago (2013-02-06 16:03:05 UTC) #19
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=96867
7 years, 10 months ago (2013-02-06 17:22:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/12184012/17004
7 years, 10 months ago (2013-02-06 17:46:41 UTC) #21
commit-bot: I haz the power
7 years, 10 months ago (2013-02-06 19:12:44 UTC) #22
Message was sent while issue was closed.
Change committed as 181018

Powered by Google App Engine
This is Rietveld 408576698