Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 12183030: Revert cross-origin auth prompt blocking. (Closed)

Created:
7 years, 10 months ago by Tom Sepez
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert cross-origin auth prompt blocking. BUG=174129 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181113

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Tom Sepez
adding @sky for owners.
7 years, 10 months ago (2013-02-04 22:39:23 UTC) #1
sky
I'm not familiar enough with this, please pick another reviewer.
7 years, 10 months ago (2013-02-04 22:51:52 UTC) #2
Tom Sepez
@creis - looks like you're an owner for this area, too.
7 years, 10 months ago (2013-02-04 22:53:20 UTC) #3
Charlie Reis
Seems reasonable but an improved comment might make it clearer how we can fix this ...
7 years, 10 months ago (2013-02-04 23:31:40 UTC) #4
Tom Sepez
Ok. See new comment.
7 years, 10 months ago (2013-02-05 00:10:28 UTC) #5
Charlie Reis
Great, thanks. LGTM.
7 years, 10 months ago (2013-02-05 01:33:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/12183030/4001
7 years, 10 months ago (2013-02-05 17:24:55 UTC) #7
commit-bot: I haz the power
Presubmit check for 12183030-4001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-02-05 17:24:57 UTC) #8
Tom Sepez
+ben for ui/OWNERS.
7 years, 10 months ago (2013-02-05 19:50:23 UTC) #9
Ben Goodger (Google)
lgtm
7 years, 10 months ago (2013-02-06 19:00:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/12183030/4001
7 years, 10 months ago (2013-02-06 19:05:54 UTC) #11
commit-bot: I haz the power
7 years, 10 months ago (2013-02-07 00:32:38 UTC) #12
Message was sent while issue was closed.
Change committed as 181113

Powered by Google App Engine
This is Rietveld 408576698