Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 12181010: Make TestWebIDBFactory allocate a separate WebIDBFactory per thread. (Closed)

Created:
7 years, 10 months ago by darin (slow to review)
Modified:
7 years, 10 months ago
Reviewers:
gavinp, alecflett
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Make TestWebIDBFactory allocate a separate WebIDBFactory per thread. This allows the main WebKit thread and web worker threads to each get their own WebIDBFactory instance, which mimics the behavior when we let the WebIDBFactory be instantiated via the WebKitPlatformSupport::idbFactory() method. R=alecflett@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180583

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -84 lines) Patch
A webkit/support/test_webidbfactory.h View 1 chunk +53 lines, -0 lines 0 comments Download
A webkit/support/test_webidbfactory.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M webkit/support/webkit_support.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 5 chunks +4 lines, -13 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
darin (slow to review)
7 years, 10 months ago (2013-02-04 08:21:18 UTC) #1
jsbell
On 2013/02/04 08:21:18, darin wrote: I'm out sick today and and in no shape to ...
7 years, 10 months ago (2013-02-04 18:11:35 UTC) #2
darin (slow to review)
over to alec b/c i just ran into him and verbally described this change
7 years, 10 months ago (2013-02-04 18:35:59 UTC) #3
alecflett
On 2013/02/04 18:35:59, darin wrote: > over to alec b/c i just ran into him ...
7 years, 10 months ago (2013-02-04 18:49:25 UTC) #4
darin (slow to review)
What I observed is that WebIDBFactory::create() returns a WebKit::WebIDBFactoryImpl instance, which is not thread safe. ...
7 years, 10 months ago (2013-02-04 19:03:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/12181010/7005
7 years, 10 months ago (2013-02-04 22:34:58 UTC) #6
commit-bot: I haz the power
Change committed as 180583
7 years, 10 months ago (2013-02-05 00:42:01 UTC) #7
gavinp
7 years, 10 months ago (2013-02-05 19:52:09 UTC) #8
Message was sent while issue was closed.
I reverted this in
http://src.chromium.org/viewvc/chrome?view=rev&revision=180758

Powered by Google App Engine
This is Rietveld 408576698