Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: tests/test_parse_master/expected-comment.html

Issue 12178026: Adds console renderer to merger backend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/chromium-build
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <tr>
2 <td colspan="6" class="DevComment ">
3 Add SpeechInputBubbleViews::notify_delegate_on_activation_change_, etc.<br />Ensure SpeechInputBubbleView continues observing its Widget as it&#39;s close d.<br />Needed so BubbleDelegateView::OnWidgetClosing will close the border widg et.<br /><br />Only notify the SpeechInputBubbleView&#39;s delegate when the act ivation changes through normal user interaction. The SpeechInputBubbleController deletes the SpeechInputBubbleImpl to close it explicitly, and then doesn&#39;t expect to be notified on that loss of focus/activation.<br /><br />BUG=98323,112 194<br />TEST=SpeechInputBubbles behave as expected.<br /><br />Review URL: http ://codereview.chromium.org/9370006 1 Add SpeechInputBubbleViews::notify_delegate_on_activation_change_, etc.<br />Ensure SpeechInputBubbleView continues observing its Widget as it&#39;s close d.<br />Needed so BubbleDelegateView::OnWidgetClosing will close the border widg et.<br /><br />Only notify the SpeechInputBubbleView&#39;s delegate when the act ivation changes through normal user interaction. The SpeechInputBubbleController deletes the SpeechInputBubbleImpl to close it explicitly, and then doesn&#39;t expect to be notified on that loss of focus/activation.<br /><br />BUG=98323,112 194<br />TEST=SpeechInputBubbles behave as expected.<br /><br />Review URL: http ://codereview.chromium.org/9370006
4 </td>
5 </tr>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698