Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 12178023: Merge 179932 - Ensure that ChromeFrame does not interfere with non ChromeFrame requests initiated b… (Closed)

Created:
7 years, 10 months ago by ananta
Modified:
7 years, 10 months ago
Reviewers:
ananta
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Merge 179932 - Ensure that ChromeFrame does not interfere with non ChromeFrame requests initiated by IE. ChromeFrame patches the urlmon transaction object vtable to ensure that top level requests initiated by IE are intercepted. Methods patched include the Start/StartEx and Read. The Read method is patched to ensure that we return unprocessed data back to urlmon in case the site is not switched into ChromeFrame. There is a race condition between the time the data is discarded and a new request is created as the IInternetProtocol interface ptr can be reused. This causes us to return stale data from a previous request to IE. The data is keyed off the IInternetProtocol interface ptr. Fix is to patch the Abort and Terminate methods of the transaction vtable and destroy the data for the protocol. Fixes bug http://code.google.com/p/chromium/issues/detail?id=168308 BUG=168308 Review URL: https://chromiumcodereview.appspot.com/12093077 TBR=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M chrome_frame/protocol_sink_wrap.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome_frame/protocol_sink_wrap.cc View 4 chunks +44 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
7 years, 10 months ago (2013-02-04 19:51:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698