Issue 12178017: Tag stubs that rely on instance types as MEGAMORPHIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12178017: Tag stubs that rely on instance types as MEGAMORPHIC. (Closed)

Created:
7 years, 10 months ago by Toon Verwaest

Modified:
7 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Tag stubs that rely on instance types as MEGAMORPHIC. BUG=chromium:173974 Committed: https://code.google.com/p/v8/source/detail?r=13586

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
M	src/builtins.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs.h	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-173974.js	View		1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. https://chromiumcodereview.appspot.com/12178017/diff/2001/src/code-stubs.h File src/code-stubs.h (right): https://chromiumcodereview.appspot.com/12178017/diff/2001/src/code-stubs.h#newcode553 src/code-stubs.h:553: // TODO(verwaest): These stubs should collect ...

7 years, 10 months ago (2013-02-04 13:04:06 UTC) #2

addressed nits.

Expand Messages | Collapse Messages

Issue 12178017: Tag stubs that rely on instance types as MEGAMORPHIC. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages