Issue 12177022: Adding field trial branching code to use either the modal dialog or the bubble for sing in confirma…

Issue 12177022: Adding field trial branching code to use either the modal dialog or the bubble for sing in confirma… (Closed)

Created:
7 years, 10 months ago by jwd

Modified:
7 years, 10 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing), bcwhite

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding field trial branching code to use either the modal dialog or the bubble for sing in confirmation. BUG=174120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181012

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	build/common.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/sync/one_click_signin_helper.cc	View		3 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

https://codereview.chromium.org/12177022/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12177022/diff/1/build/common.gypi#newcode490 build/common.gypi:490: ['OS=="win" or OS=="mac" or (OS=="linux")', { I think you ...

7 years, 10 months ago (2013-02-05 16:52:03 UTC) #1

jwd

7 years, 10 months ago (2013-02-05 18:10:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/12177022/4001

7 years, 10 months ago (2013-02-06 16:02:11 UTC) #4

Message was sent while issue was closed.

Change committed as 181012

Expand Messages | Collapse Messages