Refactor implementation for String.prototype.replace.

Refactor implementation for String.prototype.replace.

R=ulan@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13761

[ulan, 2013-02-05 09:30:58]

LGTM if the comments are addressed.

https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js
File src/string.js (left):

https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js#oldco...
src/string.js:285: search = TO_STRING_INLINE(search);
Looks like it was remove accidentally.

https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js
File src/string.js (right):

https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js#newco...
src/string.js:271: SubString(subject, match[CAPTURE1], subject.length);
I would reformat by putting the first argument of ExpandReplacement in a new
line.

https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js#newco...
src/string.js:369: %_StringCharCodeAt(string, position + 1) != 49) {  // not
'$01'
As discussed offline, we should check $02, ... $nn here too.

[Yang, 2013-02-05 10:47:32]

I addressed the comments. Please take another look.

https://codereview.chromium.org/12177015/diff/3001/src/string.js
File src/string.js (right):

https://codereview.chromium.org/12177015/diff/3001/src/string.js#newcode271
src/string.js:271: SubString(subject, match[CAPTURE1], subject.length);
On 2013/02/05 09:30:58, ulan wrote:
> I would reformat by putting the first argument of ExpandReplacement in a new
> line.

Not entirely sure what you mean here.

[Yang, 2013-02-27 14:14:51]

Committed patchset #5 manually as r13761 (presubmit successful).