Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 12161003: Make gaia and oauth token fetchers recover from ERR_NETWORK_CHANGED. (Closed)

Created:
7 years, 10 months ago by Joao da Silva
Modified:
7 years, 10 months ago
Reviewers:
zel
CC:
chromium-reviews
Visibility:
Public.

Description

Make gaia and oauth token fetchers recover from ERR_NETWORK_CHANGED. This net error occurs frequently during ChromeOS sign-in when tokens are being fetched, due to network change notifications triggered by the network library, the portal detector and sometimes proxy configuration changes. BUG=173671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M google_apis/gaia/gaia_auth_fetcher.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M google_apis/gaia/oauth2_mint_token_fetcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M google_apis/gaia/oauth2_revocation_fetcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
Zel, I think this is the root cause of the recent bugs with sync not ...
7 years, 10 months ago (2013-02-01 17:40:08 UTC) #1
Joao da Silva
@Zel, can you have a look or assign to someone to review? Thanks!
7 years, 10 months ago (2013-02-04 19:14:57 UTC) #2
zel
lgtm
7 years, 10 months ago (2013-02-04 19:31:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/12161003/1
7 years, 10 months ago (2013-02-04 19:34:11 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-04 23:15:34 UTC) #5
Message was sent while issue was closed.
Change committed as 180550

Powered by Google App Engine
This is Rietveld 408576698