MessageLoop's RUN method will pass a const ref to PendingTask when

MessageLoop's RUN method will pass a const ref to PendingTask when
TaskObserver's WillProcessTask and DidProcessTask methods are called.

User's of TaskObserver get time_posted by accessing pending_task.time_posted.

User's of TaskObserver get time_posted by accessing pending_task.time_posted.
(would like to use this with SpdySession testing to verify a task is posted
or not).

R=jar@chromium.org, darin@chromium.org
TESTS= all unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180302

[jar (doing other things), 2013-02-01 23:07:34]

lgtm

[ramant (doing other things), 2013-02-01 23:38:01]

Hi Darin,
  Would appreciate if you could take a look at this change.
thanks

[darin (slow to review), 2013-02-02 00:32:46]

https://codereview.chromium.org/12161002/diff/9019/media/audio/mac/audio_devi...
File media/audio/mac/audio_device_listener_mac.cc (right):

https://codereview.chromium.org/12161002/diff/9019/media/audio/mac/audio_devi...
media/audio/mac/audio_device_listener_mac.cc:33: base::PendingTask
pending_task(CreateQuitPendingTask());
why create a Quit task here?  why not just a no-op task?  you could bind to
base::DoNothing.

[ramant (doing other things), 2013-02-02 01:38:55]

Many many thanks for your quick review and comments. Made the changes you have
suggested.

https://codereview.chromium.org/12161002/diff/9019/media/audio/mac/audio_devi...
File media/audio/mac/audio_device_listener_mac.cc (right):

https://codereview.chromium.org/12161002/diff/9019/media/audio/mac/audio_devi...
media/audio/mac/audio_device_listener_mac.cc:33: base::PendingTask
pending_task(CreateQuitPendingTask());
On 2013/02/02 00:32:46, darin wrote:
> why create a Quit task here?  why not just a no-op task?  you could bind to
> base::DoNothing.

Done.

[darin (slow to review), 2013-02-02 07:05:23]

https://codereview.chromium.org/12161002/diff/38002/media/audio/mac/audio_dev...
File media/audio/mac/audio_device_listener_mac.cc (right):

https://codereview.chromium.org/12161002/diff/38002/media/audio/mac/audio_dev...
media/audio/mac/audio_device_listener_mac.cc:44: if
(message_loop_->message_loop_proxy()->BelongsToCurrentThread()) {
By the way, and sorry for not mentioning this the first time around, but it
seems like a better solution would be to just refactor the guts of
DidProcessTask and WillProcessTask into helper functions that you can then just
call directly.  Constructing a synthetic PendingTask seems hacky.

[ramant (doing other things), 2013-02-02 18:20:09]

Would appreciate if you could take another look.

thanks
raman

https://codereview.chromium.org/12161002/diff/38002/media/audio/mac/audio_dev...
File media/audio/mac/audio_device_listener_mac.cc (right):

https://codereview.chromium.org/12161002/diff/38002/media/audio/mac/audio_dev...
media/audio/mac/audio_device_listener_mac.cc:44: if
(message_loop_->message_loop_proxy()->BelongsToCurrentThread()) {
On 2013/02/02 07:05:24, darin wrote:
> By the way, and sorry for not mentioning this the first time around, but it
> seems like a better solution would be to just refactor the guts of
> DidProcessTask and WillProcessTask into helper functions that you can then
just
> call directly.  Constructing a synthetic PendingTask seems hacky.

Many many thanks for your time and the above suggestion.

Done.

[darin (slow to review), 2013-02-03 04:31:41]

LGTM

[commit-bot: I haz the power, 2013-02-03 06:26:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/12161002/30006

[commit-bot: I haz the power, 2013-02-03 08:16:27]

Change committed as 180302