Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1215233003: Reland - Omnibox - Mark As Duplicates URLs that only differ by a trailing slash (Closed)

Created:
5 years, 5 months ago by Mark P
Modified:
4 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland - Omnibox - Mark As Duplicates URLs that only differ by a trailing slash Make the stripped URL always end the path component in a trailing slash. previous attempt: https://chromium.googlesource.com/chromium/src.git/+/86d6ea9832f60721adc36a3372b51016947dfcb2 Plus (this is what will make this attempt work), have each provider strip "/" in inline autocompletion aggressively BUG=490084, 501048

Patch Set 1 #

Patch Set 2 : move const #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -17 lines) Patch
M components/omnibox/autocomplete_match.h View 3 chunks +24 lines, -10 lines 2 comments Download
M components/omnibox/autocomplete_match.cc View 1 2 chunks +24 lines, -0 lines 3 comments Download
M components/omnibox/autocomplete_match_unittest.cc View 1 chunk +36 lines, -0 lines 1 comment Download
M components/omnibox/bookmark_provider.cc View 1 chunk +2 lines, -1 line 1 comment Download
M components/omnibox/builtin_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/history_quick_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/omnibox/history_url_provider.cc View 1 chunk +3 lines, -5 lines 1 comment Download
M components/omnibox/search_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/shortcuts_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Mark P
Hey, Please take a look at this proposed solution and let me know what you ...
5 years, 5 months ago (2015-06-30 23:47:30 UTC) #2
Peter Kasting
https://codereview.chromium.org/1215233003/diff/20001/components/omnibox/autocomplete_match.cc File components/omnibox/autocomplete_match.cc (right): https://codereview.chromium.org/1215233003/diff/20001/components/omnibox/autocomplete_match.cc#newcode569 components/omnibox/autocomplete_match.cc:569: static const base::char16 slash_utf8 = 0x002F; Why declare a ...
5 years, 5 months ago (2015-07-01 22:01:36 UTC) #3
Peter Kasting
Mark, what's the story here?
4 years, 7 months ago (2016-04-29 02:10:12 UTC) #4
Mark P
On 2016/04/29 02:10:12, Peter Kasting wrote: > Mark, what's the story here? I do not ...
4 years, 7 months ago (2016-04-29 04:05:07 UTC) #5
Peter Kasting
4 years, 7 months ago (2016-04-29 05:01:57 UTC) #6
On 2016/04/29 04:05:07, Mark P wrote:
> On 2016/04/29 02:10:12, Peter Kasting wrote:
> > Mark, what's the story here?
> 
> I do not plan to revive this.  I don't think it'll do much; other things on my
> plate are more important.

Closing.

Powered by Google App Engine
This is Rietveld 408576698