Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1215233002: [Feedback] Add support for using callbacks for ConnectivityTask (Closed)

Created:
5 years, 5 months ago by nyquist
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@add-connectivity-task-enum
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Feedback] Add support for using callbacks for ConnectivityTask Currently the ConnectivityTask for gathering data about connectivity only supported polling for the data. This CL changes it to also support an optional callback which will be called when all results have been gathered, or the timeout has been hit. BUG=386395 Committed: https://crrev.com/6181f2772f5d0c0696e9cdff1b73d3b69eb224f4 Cr-Commit-Position: refs/heads/master@{#337109}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/feedback/ConnectivityTask.java View 4 chunks +33 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java View 1 2 4 chunks +73 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
nyquist
dfalcantara: PTAL
5 years, 5 months ago (2015-06-30 21:02:46 UTC) #2
gone
lgtm
5 years, 5 months ago (2015-07-01 15:58:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215233002/30004
5 years, 5 months ago (2015-07-01 19:53:34 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:30004)
5 years, 5 months ago (2015-07-01 20:33:28 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 20:34:26 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6181f2772f5d0c0696e9cdff1b73d3b69eb224f4
Cr-Commit-Position: refs/heads/master@{#337109}

Powered by Google App Engine
This is Rietveld 408576698