Issue 12151002: Initialize memory, remove valgrind supression, add transparency test.

Issue 12151002: Initialize memory, remove valgrind supression, add transparency test. (Closed)

Created:
7 years, 10 months ago by Harry McCleave

Modified:
7 years, 10 months ago

Reviewers:
oshima, sky

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Initialize memory, remove valgrind supression, add transparency test. BUG=166584 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180101

Patch Set 2 : clear -> erase, add comment. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
	M	ui/gfx/skbitmap_operations_unittest.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Harry McCleave

Ready for review, first time removing a suppression is this the correct set of changes?

7 years, 10 months ago (2013-01-31 23:14:18 UTC) #1

danakj

Seems fine to me be I'm not owners of that file, geometry types only.

7 years, 10 months ago (2013-01-31 23:17:35 UTC) #2

oshima

https://codereview.chromium.org/12151002/diff/1/ui/gfx/skbitmap_operations_unittest.cc File ui/gfx/skbitmap_operations_unittest.cc (right): https://codereview.chromium.org/12151002/diff/1/ui/gfx/skbitmap_operations_unittest.cc#newcode534 ui/gfx/skbitmap_operations_unittest.cc:534: src.allocPixels(); I think src.eraseARGB(0, 0, 0, 0); is what ...

7 years, 10 months ago (2013-01-31 23:34:25 UTC) #3

Harry McCleave

On 2013/01/31 23:34:25, oshima wrote: > https://codereview.chromium.org/12151002/diff/1/ui/gfx/skbitmap_operations_unittest.cc > File ui/gfx/skbitmap_operations_unittest.cc (right): > > https://codereview.chromium.org/12151002/diff/1/ui/gfx/skbitmap_operations_unittest.cc#newcode534 > ...

7 years, 10 months ago (2013-01-31 23:55:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/12151002/4001

7 years, 10 months ago (2013-02-01 00:50:35 UTC) #6

Message was sent while issue was closed.

Change committed as 180101

Expand Messages | Collapse Messages