Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chrome/test/automation/automation_proxy.h

Issue 12150004: Category group support/Renamings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Added destructor for CategoryFilter class per CQ failure. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/automation_messages_internal.h ('k') | chrome/test/automation/automation_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/automation_proxy.h
diff --git a/chrome/test/automation/automation_proxy.h b/chrome/test/automation/automation_proxy.h
index 788a3dc9d0f69962bf6756b96730f290fd169822..3dfb7f1f6b0560c7c2236b5ef2dd8923a9a67dcc 100644
--- a/chrome/test/automation/automation_proxy.h
+++ b/chrome/test/automation/automation_proxy.h
@@ -153,19 +153,21 @@ class AutomationProxy : public IPC::Listener, public AutomationMessageSender {
int timeout_ms,
std::string* response) WARN_UNUSED_RESULT;
- // Begin tracing specified categories on the browser instance. Blocks until
- // browser acknowledges that tracing has begun (or failed if false is
- // returned). |categories| is a comma-delimited list of category wildcards.
- // A category can have an optional '-' prefix to make it an excluded category.
- // Either all categories must be included or all must be excluded.
+ // Begin tracing specified category_patterns on the browser instance. Blocks
+ // until browser acknowledges that tracing has begun (or failed if false is
+ // returned). |category_patterns| is a comma-delimited list of category
+ // wildcards.
+ // A category pattern can have an optional '-' prefix to exclude category
+ // groups that contain matching category.
+ // Either all category_patterns must be included or all must be excluded.
//
// Example: BeginTracing("test_MyTest*");
// Example: BeginTracing("test_MyTest*,test_OtherStuff");
// Example: BeginTracing("-excluded_category1,-excluded_category2");
//
// See base/event_trace.h for documentation of included and excluded
- // categories.
- bool BeginTracing(const std::string& categories) WARN_UNUSED_RESULT;
+ // category_patterns.
+ bool BeginTracing(const std::string& category_patterns) WARN_UNUSED_RESULT;
// End trace and collect the trace output as a json string.
bool EndTracing(std::string* json_trace_output) WARN_UNUSED_RESULT;
« no previous file with comments | « chrome/common/automation_messages_internal.h ('k') | chrome/test/automation/automation_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698