chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java - Issue 1214723012: Track whether a created WebContents has a resume pending.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

Issue 1214723012: Track whether a created WebContents has a resume pending. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

index 72ff21d01171126c3d6943f8d87bf1cf3b7de1fa..22b2936af6a8fd273edb152d22292fdc1eda6766 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

@@ -107,16 +107,12 @@ public class TabDelegate implements TabCreator {

Context context = ApplicationStatus.getApplicationContext();

int pageTransition = startedBy == DocumentMetricIds.STARTED_BY_CHROME_HOME_RECENT_TABS

? PageTransition.RELOAD : PageTransition.AUTO_TOPLEVEL;

- // TODO(dfalcantara): Pipe information about paused WebContents from native.

- boolean isWebContentsPaused =

- startedBy != DocumentMetricIds.STARTED_BY_CHROME_HOME_RECENT_TABS;

Activity parentActivity = getActivityForTabId(parentId);

if (FeatureUtilities.isDocumentMode(context)) {

PendingDocumentData data = new PendingDocumentData();

data.webContents = webContents;

- data.webContentsPaused = isWebContentsPaused;

ChromeLauncherActivity.launchDocumentInstance(parentActivity, mIsIncognito,

ChromeLauncherActivity.LAUNCH_MODE_FOREGROUND, url, startedBy, pageTransition,

@@ -128,7 +124,6 @@ public class TabDelegate implements TabCreator {

tabbedIntent.setClass(context, ChromeLauncherActivity.class);

tabbedIntent.putExtra(IntentHandler.EXTRA_OPEN_NEW_INCOGNITO_TAB, mIsIncognito);

tabbedIntent.putExtra(IntentHandler.EXTRA_WEB_CONTENTS, webContents);

- tabbedIntent.putExtra(IntentHandler.EXTRA_WEB_CONTENTS_PAUSED, isWebContentsPaused);

tabbedIntent.putExtra(IntentHandler.EXTRA_PAGE_TRANSITION_TYPE, pageTransition);

tabbedIntent.putExtra(IntentHandler.EXTRA_PARENT_TAB_ID, parentId);