Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: chrome/browser/system_monitor/media_storage_util.cc

Issue 12147002: Add a receiver interface to RemovableStorageNotifications. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Merging Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/system_monitor/media_storage_util.cc
diff --git a/chrome/browser/system_monitor/media_storage_util.cc b/chrome/browser/system_monitor/media_storage_util.cc
index 18d8b3da181530aa8edfd2bac1917f3ba4313bd6..3c567aa83694b118c95a2e3f05e95f6d75a0dc53 100644
--- a/chrome/browser/system_monitor/media_storage_util.cc
+++ b/chrome/browser/system_monitor/media_storage_util.cc
@@ -269,12 +269,18 @@ bool MediaStorageUtil::GetDeviceInfoFromPath(const base::FilePath& path,
if (!path.IsAbsolute())
return false;
+ // TODO(gbillock): Eliminate this in favor of a mock storage notifications.
if (g_test_get_device_info_from_path_function) {
return g_test_get_device_info_from_path_function(path, device_id,
device_name,
relative_path);
}
+ // TODO(gbillock): rationalize this sequence into call(s) to
+ // RemovableStorageNotifications and uniform use/loading of
+ // the display name into StorageInfo, or else delegate name
+ // construction as well.
+
bool found_device = false;
RemovableStorageNotifications::StorageInfo device_info;
#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_WIN)

Powered by Google App Engine
This is Rietveld 408576698