Fix painting of scaled themes in Windows in high-DPI mode.

Fix painting of scaled themes in Windows in high-DPI mode.

BUG=149881
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180431

[kevers, 2013-02-01 16:33:05]

Hi Scott,

Can you please take a look at this CL.

[sky, 2013-02-01 17:09:57]

https://codereview.chromium.org/12114049/diff/2001/ui/native_theme/native_the...
File ui/native_theme/native_theme_win.cc (right):

https://codereview.chromium.org/12114049/diff/2001/ui/native_theme/native_the...
ui/native_theme/native_theme_win.cc:1604: GetWorldTransform(hdc,
&save_transform);
Don't you need to check the return value?

https://codereview.chromium.org/12114049/diff/2001/ui/native_theme/native_the...
ui/native_theme/native_theme_win.cc:1607: ModifyWorldTransform(hdc, NULL,
MWT_IDENTITY);
I'm not too familiar with this, but should we consider setting this in a more
central location so we don't have to change it every where?

[kevers, 2013-02-01 18:03:31]

https://codereview.chromium.org/12114049/diff/2001/ui/native_theme/native_the...
File ui/native_theme/native_theme_win.cc (right):

https://codereview.chromium.org/12114049/diff/2001/ui/native_theme/native_the...
ui/native_theme/native_theme_win.cc:1604: GetWorldTransform(hdc,
&save_transform);
On 2013/02/01 17:09:57, sky wrote:
> Don't you need to check the return value?

Done.

https://codereview.chromium.org/12114049/diff/2001/ui/native_theme/native_the...
ui/native_theme/native_theme_win.cc:1607: ModifyWorldTransform(hdc, NULL,
MWT_IDENTITY);
On 2013/02/01 17:09:57, sky wrote:
> I'm not too familiar with this, but should we consider setting this in a more
> central location so we don't have to change it every where?

The transformation addresses an issue with the Windows API method
DrawBackgroundTheeme, which draw_theme_ maps to.  It is unclear at this time how
many other places we will need to do similar transformations.  Certainly, if a
pattern emerges, it makes sense to collect the transformations into a common set
of utility methods.

[sky, 2013-02-01 20:16:45]

LGTM

[commit-bot: I haz the power, 2013-02-01 21:35:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/12114049/6001

[commit-bot: I haz the power, 2013-02-04 15:14:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/12114049/6001

[commit-bot: I haz the power, 2013-02-04 17:03:14]

Change committed as 180431