Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Issue 12114017: Remove redundant buffer count in ExynosVDA (Closed)

Created:
7 years, 10 months ago by sheu
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@git-svn
Visibility:
Public.

Description

Remove redundant buffer count in ExynosVDA Remove the redundant output buffer total count. One less piece of state to possibly lose track of. BUG=None TEST=local build, run on snow Change-Id: I132065be3c21226fabc13a9bcda9784e58ecd218 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179869

Patch Set 1 #

Total comments: 6

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -48 lines) Patch
M content/common/gpu/media/exynos_video_decode_accelerator.h View 1 5 chunks +1 line, -9 lines 0 comments Download
M content/common/gpu/media/exynos_video_decode_accelerator.cc View 1 20 chunks +19 lines, -39 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sheu
Should be a simple one. PTAL.
7 years, 10 months ago (2013-01-31 00:13:44 UTC) #1
Ami GONE FROM CHROMIUM
LGTM % nits https://chromiumcodereview.appspot.com/12114017/diff/1/content/common/gpu/media/exynos_video_decode_accelerator.cc File content/common/gpu/media/exynos_video_decode_accelerator.cc (left): https://chromiumcodereview.appspot.com/12114017/diff/1/content/common/gpu/media/exynos_video_decode_accelerator.cc#oldcode1863 content/common/gpu/media/exynos_video_decode_accelerator.cc:1863: DVLOG(3) << "SetDecoderState(): state=%d" << state; ...
7 years, 10 months ago (2013-01-31 00:30:08 UTC) #2
sheu
Why am I so sloppy all the time? Fixed.
7 years, 10 months ago (2013-01-31 00:40:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/12114017/4001
7 years, 10 months ago (2013-01-31 00:50:14 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 11:57:47 UTC) #5
Message was sent while issue was closed.
Change committed as 179869

Powered by Google App Engine
This is Rietveld 408576698