Remove syncer::IncomingInvalidationSource

sync/notifier/p2p_invalidator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/notifier/p2p_invalidator.h"
 
 #include <algorithm>
 
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/values.h"
 #include "jingle/notifier/listener/push_client.h"
 #include "sync/notifier/invalidation_handler.h"
 #include "sync/notifier/invalidation_util.h"
 
 namespace syncer {
 
 const char kSyncP2PNotificationChannel[] = "http://www.google.com/chrome/sync";
 
 namespace {
 
 const char kNotifySelf[] = "notifySelf";
 const char kNotifyOthers[] = "notifyOthers";
 const char kNotifyAll[] = "notifyAll";
 
 const char kSenderIdKey[] = "senderId";
 const char kNotificationTypeKey[] = "notificationType";
 const char kIdInvalidationMapKey[] = "idInvalidationMap";
-const char kSourceKey[] = "source";
 
 }  // namespace
 
 std::string P2PNotificationTargetToString(P2PNotificationTarget target) {
   switch (target) {
     case NOTIFY_SELF:
       return kNotifySelf;
     case NOTIFY_OTHERS:
       return kNotifyOthers;
     case NOTIFY_ALL:
@@ skipping 12 matching lines @@
   if (target_str == kNotifyOthers) {
     return NOTIFY_OTHERS;
   }
   if (target_str == kNotifyAll) {
     return NOTIFY_ALL;
   }
   LOG(WARNING) << "Could not parse " << target_str;
   return NOTIFY_SELF;
 }
 
-IncomingInvalidationSource P2PNotificationSourceFromInteger(int source_num) {
-  if (source_num == LOCAL_INVALIDATION) {
-    return LOCAL_INVALIDATION;
-  }
-  return REMOTE_INVALIDATION;
-}
-
 P2PNotificationData::P2PNotificationData()
-    : target_(NOTIFY_SELF), source_(REMOTE_INVALIDATION) {}
+    : target_(NOTIFY_SELF) {}
 
 P2PNotificationData::P2PNotificationData(
     const std::string& sender_id,
     P2PNotificationTarget target,
-    const ObjectIdInvalidationMap& invalidation_map,
-    IncomingInvalidationSource source)
+    const ObjectIdInvalidationMap& invalidation_map)
     : sender_id_(sender_id),
       target_(target),
-      invalidation_map_(invalidation_map),
-      source_(source) {}
+      invalidation_map_(invalidation_map) {}
 
 P2PNotificationData::~P2PNotificationData() {}
 
 bool P2PNotificationData::IsTargeted(const std::string& id) const {
   switch (target_) {
     case NOTIFY_SELF:
       return sender_id_ == id;
     case NOTIFY_OTHERS:
       return sender_id_ != id;
     case NOTIFY_ALL:
       return true;
     default:
       NOTREACHED();
       return false;
   }
 }
 
 const ObjectIdInvalidationMap&
 P2PNotificationData::GetIdInvalidationMap() const {
   return invalidation_map_;
 }
 
-IncomingInvalidationSource P2PNotificationData::GetSource() const {
-  return source_;
-}
-
 bool P2PNotificationData::Equals(const P2PNotificationData& other) const {
   return
       (sender_id_ == other.sender_id_) &&
       (target_ == other.target_) &&
       ObjectIdInvalidationMapEquals(invalidation_map_,
-                                    other.invalidation_map_) &&
-      (source_ == other.source_);
+                                    other.invalidation_map_);
 }
 
 std::string P2PNotificationData::ToString() const {
   scoped_ptr<DictionaryValue> dict(new DictionaryValue());
   dict->SetString(kSenderIdKey, sender_id_);
   dict->SetString(kNotificationTypeKey,
                   P2PNotificationTargetToString(target_));
   dict->Set(kIdInvalidationMapKey,
             ObjectIdInvalidationMapToValue(invalidation_map_).release());
-  dict->SetInteger(kSourceKey, source_);
   std::string json;
   base::JSONWriter::Write(dict.get(), &json);
   return json;
 }
 
 bool P2PNotificationData::ResetFromString(const std::string& str) {
   scoped_ptr<Value> data_value(base::JSONReader::Read(str));
   const base::DictionaryValue* data_dict = NULL;
   if (!data_value.get() || !data_value->GetAsDictionary(&data_dict)) {
     LOG(WARNING) << "Could not parse " << str << " as a dictionary";
     return false;
   }
   if (!data_dict->GetString(kSenderIdKey, &sender_id_)) {
     LOG(WARNING) << "Could not find string value for " << kSenderIdKey;
   }
   std::string target_str;
   if (!data_dict->GetString(kNotificationTypeKey, &target_str)) {
     LOG(WARNING) << "Could not find string value for "
                  << kNotificationTypeKey;
   }
   target_ = P2PNotificationTargetFromString(target_str);
   const base::ListValue* invalidation_map_list = NULL;
   if (!data_dict->GetList(kIdInvalidationMapKey, &invalidation_map_list) ||
       !ObjectIdInvalidationMapFromValue(*invalidation_map_list,
                                         &invalidation_map_)) {
     LOG(WARNING) << "Could not parse " << kIdInvalidationMapKey;
   }
-  int source_num = 0;
-  if (!data_dict->GetInteger(kSourceKey, &source_num)) {
-    LOG(WARNING) << "Could not find integer value for " << kSourceKey;
-  }
-  source_ = P2PNotificationSourceFromInteger(source_num);
   return true;
 }
 
 P2PInvalidator::P2PInvalidator(scoped_ptr<notifier::PushClient> push_client,
                                P2PNotificationTarget send_notification_target)
     : push_client_(push_client.Pass()),
       logged_in_(false),
       notifications_enabled_(false),
       send_notification_target_(send_notification_target) {
   DCHECK(send_notification_target_ == NOTIFY_OTHERS ||
@@ skipping 16 matching lines @@
   // TODO(akalin): Handle arbitrary object IDs (http://crbug.com/140411).
   DCHECK(thread_checker_.CalledOnValidThread());
   ObjectIdSet new_ids;
   const ObjectIdSet& old_ids = registrar_.GetRegisteredIds(handler);
   std::set_difference(ids.begin(), ids.end(),
                       old_ids.begin(), old_ids.end(),
                       std::inserter(new_ids, new_ids.end()),
                       ObjectIdLessThan());
   registrar_.UpdateRegisteredIds(handler, ids);
   const P2PNotificationData notification_data(
-      unique_id_, NOTIFY_SELF, ObjectIdSetToInvalidationMap(new_ids, ""),
-      REMOTE_INVALIDATION);
+      unique_id_, NOTIFY_SELF, ObjectIdSetToInvalidationMap(new_ids, ""));
   SendNotificationData(notification_data);
 }
 
 void P2PInvalidator::UnregisterHandler(InvalidationHandler* handler) {
   DCHECK(thread_checker_.CalledOnValidThread());
   registrar_.UnregisterHandler(handler);
 }
 
 InvalidatorState P2PInvalidator::GetInvalidatorState() const {
   DCHECK(thread_checker_.CalledOnValidThread());
@@ skipping 19 matching lines @@
   // If already logged in, the new credentials will take effect on the
   // next reconnection.
   push_client_->UpdateCredentials(email, token);
   logged_in_ = true;
 }
 
 void P2PInvalidator::SendInvalidation(
     const ObjectIdInvalidationMap& invalidation_map) {
   DCHECK(thread_checker_.CalledOnValidThread());
   const P2PNotificationData notification_data(
-      unique_id_, send_notification_target_, invalidation_map,
-      REMOTE_INVALIDATION);
+      unique_id_, send_notification_target_, invalidation_map);
   SendNotificationData(notification_data);
 }
 
 void P2PInvalidator::OnNotificationsEnabled() {
   DCHECK(thread_checker_.CalledOnValidThread());
   bool just_turned_on = (notifications_enabled_ == false);
   notifications_enabled_ = true;
   registrar_.UpdateInvalidatorState(INVALIDATIONS_ENABLED);
   if (just_turned_on) {
     const P2PNotificationData notification_data(
         unique_id_, NOTIFY_SELF,
-        ObjectIdSetToInvalidationMap(registrar_.GetAllRegisteredIds(), ""),
-        REMOTE_INVALIDATION);
+        ObjectIdSetToInvalidationMap(registrar_.GetAllRegisteredIds(), ""));
     SendNotificationData(notification_data);
   }
 }
 
 void P2PInvalidator::OnNotificationsDisabled(
     notifier::NotificationsDisabledReason reason) {
   DCHECK(thread_checker_.CalledOnValidThread());
   registrar_.UpdateInvalidatorState(FromNotifierReason(reason));
 }
 
@@ skipping 13 matching lines @@
     LOG(WARNING) << "Notification from unexpected source "
                  << notification.channel;
   }
   P2PNotificationData notification_data;
   if (!notification_data.ResetFromString(notification.data)) {
     LOG(WARNING) << "Could not parse notification data from "
                  << notification.data;
     notification_data =
         P2PNotificationData(
             unique_id_, NOTIFY_ALL,
-            ObjectIdSetToInvalidationMap(registrar_.GetAllRegisteredIds(), ""),
-            REMOTE_INVALIDATION);
+            ObjectIdSetToInvalidationMap(registrar_.GetAllRegisteredIds(), ""));
   }
   if (!notification_data.IsTargeted(unique_id_)) {
     DVLOG(1) << "Not a target of the notification -- "
              << "not emitting notification";
     return;
   }
   registrar_.DispatchInvalidationsToHandlers(
-      notification_data.GetIdInvalidationMap(),
-      REMOTE_INVALIDATION);
+      notification_data.GetIdInvalidationMap());
 }
 
 void P2PInvalidator::SendNotificationDataForTest(
     const P2PNotificationData& notification_data) {
   DCHECK(thread_checker_.CalledOnValidThread());
   SendNotificationData(notification_data);
 }
 
 void P2PInvalidator::SendNotificationData(
     const P2PNotificationData& notification_data) {
   DCHECK(thread_checker_.CalledOnValidThread());
   if (notification_data.GetIdInvalidationMap().empty()) {
     DVLOG(1) << "Not sending XMPP notification with empty state map: "
              << notification_data.ToString();
     return;
   }
   notifier::Notification notification;
   notification.channel = kSyncP2PNotificationChannel;
   notification.data = notification_data.ToString();
   DVLOG(1) << "Sending XMPP notification: " << notification.ToString();
   push_client_->SendNotification(notification);
 }
 
 }  // namespace syncer