Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 12100007: Disable image decoding perf test for android (Closed)

Created:
7 years, 10 months ago by qinmin
Modified:
7 years, 10 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, Anthony Berent, bulach
Visibility:
Public.

Description

As chrome on android starts to use deferred image decoding, images decoding may not be captured by InspectorTimelineAgent. In such case, we cannot rely on telemetry to get the decoding time. Disable this test for now while we working on a fix. Since this test is android only, just disable it BUG=173184 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180094

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : remove method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M tools/perf/perf_tools/image_decoding_benchmark.py View 1 2 1 chunk +27 lines, -19 lines 0 comments Download
tools/perf/perf_tools/image_decoding_benchmark_unittest.py View 1 1 chunk +12 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
qinmin
PTAL
7 years, 10 months ago (2013-01-31 00:21:30 UTC) #1
tonyg
Hey Nat, I want to get your thoughts on this patch. It looks like when ...
7 years, 10 months ago (2013-01-31 01:52:10 UTC) #2
nduca
I'd prefer we disable the test. The proper way to fix this is to use ...
7 years, 10 months ago (2013-01-31 02:09:40 UTC) #3
tonyg
On 2013/01/31 02:09:40, nduca wrote: > I'd prefer we disable the test. The proper way ...
7 years, 10 months ago (2013-01-31 02:15:43 UTC) #4
qinmin
I think this test is android only, not seeing it running on other perf bots. ...
7 years, 10 months ago (2013-01-31 02:16:42 UTC) #5
qinmin
Just changed the code to disable the test and its unit test. On 2013/01/31 02:16:42, ...
7 years, 10 months ago (2013-01-31 03:05:18 UTC) #6
tonyg
lgtm https://codereview.chromium.org/12100007/diff/2002/tools/perf/perf_tools/image_decoding_benchmark.py File tools/perf/perf_tools/image_decoding_benchmark.py (right): https://codereview.chromium.org/12100007/diff/2002/tools/perf/perf_tools/image_decoding_benchmark.py#newcode10 tools/perf/perf_tools/image_decoding_benchmark.py:10: tab.StartTimelineRecording() Should probably comment out this whole method ...
7 years, 10 months ago (2013-01-31 23:20:07 UTC) #7
qinmin
https://codereview.chromium.org/12100007/diff/2002/tools/perf/perf_tools/image_decoding_benchmark.py File tools/perf/perf_tools/image_decoding_benchmark.py (right): https://codereview.chromium.org/12100007/diff/2002/tools/perf/perf_tools/image_decoding_benchmark.py#newcode10 tools/perf/perf_tools/image_decoding_benchmark.py:10: tab.StartTimelineRecording() On 2013/01/31 23:20:07, tonyg wrote: > Should probably ...
7 years, 10 months ago (2013-01-31 23:50:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/12100007/10001
7 years, 10 months ago (2013-01-31 23:58:19 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 05:58:55 UTC) #10
Message was sent while issue was closed.
Change committed as 180094

Powered by Google App Engine
This is Rietveld 408576698