Enable dictionary sync by default

Enable dictionary sync by default

This CL enables dictionary sync by default on all platforms except Android and
Mac, which do not use the Chrome custom spelling dictionary file.

BUG=72910
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181430

[please use gerrit instead, 2013-02-01 19:08:40]

Groby: PTAL

[please use gerrit instead, 2013-02-01 19:09:40]

Zea: Is this the correct way to avoid registering the dictionary sync data type
on Android and Mac?

[Nicolas Zea, 2013-02-01 19:13:14]

On 2013/02/01 19:09:40, Rouslan Solomakhin wrote:
> Zea: Is this the correct way to avoid registering the dictionary sync data
type
> on Android and Mac?

Yep. That said, we like to keep around a command line switch that lets you
disable the type (i.e. --disable-sync-dictionary). This is useful in case a
startup crash is found related to that datatype.

[please use gerrit instead, 2013-02-01 19:56:06]

Nicolas: I've added --disable-sync-dictionary flag. PTAL.

[Nicolas Zea, 2013-02-01 19:59:09]

I'd say you don't need to keep an experiment in about flags, the chrome switch
alone should be fine. Aside from that LGTM.

[please use gerrit instead, 2013-02-01 20:21:08]

On 2013/02/01 19:59:09, Nicolas Zea wrote:
> I'd say you don't need to keep an experiment in about flags, the chrome switch
> alone should be fine.

Removed experiment from about flags.

[groby-ooo-7-16, 2013-02-01 22:27:56]

LGTM minus one nit

https://codereview.chromium.org/12096116/diff/8002/chrome/browser/sync/profil...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/12096116/diff/8002/chrome/browser/sync/profil...
chrome/browser/sync/profile_sync_components_factory_impl.cc:238: #if
!defined(OS_ANDROID) && !defined(OS_MACOSX)
I'd rather explicitly enable it for a fixed set of platforms than exclude a
fixed set of platforms.

I.e. #if defined(OS_LINUX) || defined (OS_WIN) || defined(OS_CROS)

[please use gerrit instead, 2013-02-01 22:34:29]

https://codereview.chromium.org/12096116/diff/8002/chrome/browser/sync/profil...
File chrome/browser/sync/profile_sync_components_factory_impl.cc (right):

https://codereview.chromium.org/12096116/diff/8002/chrome/browser/sync/profil...
chrome/browser/sync/profile_sync_components_factory_impl.cc:238: #if
!defined(OS_ANDROID) && !defined(OS_MACOSX)
On 2013/02/01 22:27:56, groby wrote:
> I'd rather explicitly enable it for a fixed set of platforms than exclude a
> fixed set of platforms.
> 
> I.e. #if defined(OS_LINUX) || defined (OS_WIN) || defined(OS_CROS)
> 

Done.

[commit-bot: I haz the power, 2013-02-01 22:35:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/12096116/19001

[commit-bot: I haz the power, 2013-02-01 23:21:50]

Retried try job too often on linux_aura for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-02-04 17:32:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/12096116/24001

[commit-bot: I haz the power, 2013-02-04 20:51:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/12096116/30016

[commit-bot: I haz the power, 2013-02-04 21:32:18]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-02-04 22:13:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/12096116/42002

[commit-bot: I haz the power, 2013-02-05 16:35:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/12096116/42002

[commit-bot: I haz the power, 2013-02-08 02:17:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/12096116/50001

[commit-bot: I haz the power, 2013-02-08 02:17:49]

Failed to apply patch for chrome/app/generated_resources.grd:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/app/generated_resources.grd
  Hunk #1 FAILED at 7144.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/app/generated_resources.grd.rej

Patch:       chrome/app/generated_resources.grd
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd
b/chrome/app/generated_resources.grd
index
bf80850692e9ce7768a1da8bdff95c898042d1fe..7f45a1ecbba71fc24ca417e323830ada61e25a8f
100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -7144,12 +7144,6 @@ Keep your key file in a safe place. You will need it to
create new versions of y
       <message name="IDS_FLAGS_ENABLE_RICH_NOTIFICATIONS_DESCRIPTION"
desc="Description for the flag to enable rich notifications.">
         Enable rich templated notifications. Both HTML5 notifications and app
notifications will be shown through new Notification Center.
       </message>
-      <message name="IDS_FLAGS_ENABLE_SYNC_DICTIONARY_NAME" desc="Name of
about:flags option to turn on dictionary sync.">
-        Enable dictionary sync
-      </message>
-      <message name="IDS_FLAGS_ENABLE_SYNC_DICTIONARY_DESCRIPTION"
desc="Description of about:flags option to turn on dictionary sync.">
-        Enabling syncing the custom spelling dictionary. To view data, visit
chrome://settings/editDictionary.
-      </message>
 
       <!-- Crashes -->
       <message name="IDS_CRASHES_TITLE" desc="Title for the chrome://crashes
page.">

[commit-bot: I haz the power, 2013-02-08 02:24:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/12096116/53001

[commit-bot: I haz the power, 2013-02-08 05:21:37]

Change committed as 181430