Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 12096098: [cc] Add stub for IsCheapInRect (Closed)

Created:
7 years, 10 months ago by nduca
Modified:
7 years, 10 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

[cc] Add stub for IsCheapInRect R=enne CC=tomhudson,vmpstr BUG=173426 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180092

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M cc/picture.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/picture.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nduca
ptal
7 years, 10 months ago (2013-01-31 21:29:50 UTC) #1
enne (OOO)
https://codereview.chromium.org/12096098/diff/1/cc/picture.cc File cc/picture.cc (right): https://codereview.chromium.org/12096098/diff/1/cc/picture.cc#newcode95 cc/picture.cc:95: void Picture::IsCheapInRect(gfx::Rect contents, float contents_scale) { Did you mean ...
7 years, 10 months ago (2013-01-31 21:34:36 UTC) #2
nduca
I'd like to leave it to a boolean, "cheap or not" for now. Lets evolve ...
7 years, 10 months ago (2013-01-31 21:38:53 UTC) #3
nduca
ok name updated, ptal
7 years, 10 months ago (2013-01-31 21:47:22 UTC) #4
enne (OOO)
lgtm
7 years, 10 months ago (2013-01-31 23:51:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12096098/12004
7 years, 10 months ago (2013-01-31 23:58:11 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 05:58:30 UTC) #7
Message was sent while issue was closed.
Change committed as 180092

Powered by Google App Engine
This is Rietveld 408576698