Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/renderer/autofill/form_autofill_util.cc

Issue 12096074: Revert 179491 due to performance regression. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/autofill/heuristics/output/02_checkout_advanceautoparts.com.out » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/autofill/form_autofill_util.cc
===================================================================
--- chrome/renderer/autofill/form_autofill_util.cc (revision 179750)
+++ chrome/renderer/autofill/form_autofill_util.cc (working copy)
@@ -574,14 +574,21 @@
}
bool IsCheckableElement(const WebInputElement* element) {
+ // Is static for improving performance.
+ CR_DEFINE_STATIC_LOCAL(WebString, kRadio, ("radio"));
+ CR_DEFINE_STATIC_LOCAL(WebString, kCheckbox, ("checkbox"));
+
if (!element)
return false;
- return element->isCheckbox() || element->isRadioButton();
+ WebString formControlType = element->formControlType();
+ return formControlType == kCheckbox || formControlType == kRadio;
}
bool IsAutofillableInputElement(const WebInputElement* element) {
- return IsTextInput(element) || IsCheckableElement(element);
+ // TODO(ramankk): Uncomment IsCheckableElement part once we have solution
+ // for the observed performance regression.
+ return IsTextInput(element); // || IsCheckableElement(element);
}
const string16 GetFormIdentifier(const WebFormElement& form) {
« no previous file with comments | « no previous file | chrome/test/data/autofill/heuristics/output/02_checkout_advanceautoparts.com.out » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698