Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12096074: Revert 179491 due to performance regression. (Closed)

Created:
7 years, 10 months ago by Albert Bodenhamer
Modified:
7 years, 10 months ago
Reviewers:
Raman Kakilate
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Revert 179491 due to performance regression. BUG=173243 > Use WebInputElement.isCheckbox() and isRadioButton() API being exposed by https://bugs.webkit.org/show_bug.cgi?id=108031 > > BUG=157636 > > > Review URL: https://chromiumcodereview.appspot.com/12084024 TBR=ramankk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -199 lines) Patch
M chrome/renderer/autofill/form_autofill_util.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/02_checkout_advanceautoparts.com.out View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/02_checkout_ae.com.out View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/02_checkout_bedbathandbeyond.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/02_checkout_cafepress.com.out View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/03_checkout_cduniverse.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/03_checkout_crutchfield.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/03_checkout_gamestop.com.out View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/03_checkout_homedepot.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/03_checkout_hsn.com.out View 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/04_checkout_jr.com.out View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/04_checkout_kohls.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/04_checkout_lowes.com.out View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/05_checkout_macys.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/05_checkout_nordstrom.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/05_checkout_officemax.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/05_checkout_overstock.com.out View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/05_checkout_petco.com.out View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/06_checkout_petsmart.com.out View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/06_checkout_qvc.com.out View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/06_checkout_sears.com.out View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/06_checkout_target.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/06_checkout_urbanoutfitters.com.out View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/07_checkout_williams-sonoma.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_adobe.com.out View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_amazon.com.out View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_aol.com.out View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_continental.com.out View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_deviantart.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_ebay.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_ecomm.dell.com.out View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_epson.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_google.com.out View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/10_register_gymboree.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/10_register_hotels.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/10_register_imdb.com.out View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/10_register_live.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_livejournal.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_macys.com.out View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_myspace.com.out View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_newegg.com.out View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/12_register_officedepot.com.out View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/12_register_pyramidcollection.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/12_register_rediff.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/12_register_rei.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/13_register_rocketlawyer.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/13_register_signup.clicksor.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/13_register_signup.live.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/13_register_sourceforge.net.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/13_register_supershuttle.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/14_register_target.com.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/14_register_threadless.com.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/15_crbug_53075.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/15_crbug_64569.out View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/16_crbug_87517.out View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/16_crbug_98152.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/16_crbug_98269.out View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/16_crbug_98286.out View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/20_register_alaskaair.com.out View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Albert Bodenhamer
7 years, 10 months ago (2013-01-31 00:58:01 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698