Adding a unit test to verify the IPC channel between the network and desktop processes.

remoting/host/daemon_process_win.cc

Index: remoting/host/daemon_process_win.cc
diff --git a/remoting/host/daemon_process_win.cc b/remoting/host/daemon_process_win.cc
index 378eb520a812bf7e91467c726b1f14d31485f548..b18134e76307fef3b82a8031afed960c3a456496 100644
--- a/remoting/host/daemon_process_win.cc
+++ b/remoting/host/daemon_process_win.cc
@@ -10,6 +10,7 @@
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/process.h"
 #include "base/single_thread_task_runner.h"
 #include "base/time.h"
 #include "base/timer.h"
@@ -110,7 +111,7 @@ bool DaemonProcessWin::OnDesktopSessionAgentAttached(
   // Prepare |desktop_process| handle for sending over to the network process.
   // |desktop_pipe| is a handle in the desktop process. It will be duplicated
   // by the network process directly from the desktop process.
-  IPC::PlatformFileForTransit desktop_process_for_transit =
+  base::ProcessHandle desktop_process_for_transit =

[Sergey Ulanov, 2013/02/04 21:04:41]

Why do you need this change?

[alexeypa (please no reviews), 2013/02/04 23:45:58]

This is caused by changing DesktopSessionProxy::AttachToDesktop()'s parameter
from IPC::PlatformFileForTransit to base::ProcessHandle. This way I don't need
to add more #if defined(OS_WIN) in all places where |desktop_process| handle is
passed. It also allows me to use process utility functions on the handle without
additional #ifdefs.

I changed this code to call DuplicateHandle() to make it more apparent what is
going on here. This is a Windows-only source so it is safe.

       IPC::GetFileHandleForProcess(desktop_process, network_process_, false);
   if (desktop_process_for_transit == IPC::InvalidPlatformFileForTransit()) {
     LOG(ERROR) << "Failed to duplicate the desktop process handle";