Adding a unit test to verify the IPC channel between the network and desktop processes.

remoting/host/daemon_process_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/daemon_process.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/process.h"
 #include "base/single_thread_task_runner.h"
 #include "base/time.h"
 #include "base/timer.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/scoped_handle.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_message_macros.h"
 #include "remoting/base/auto_thread_task_runner.h"
 #include "remoting/host/chromoting_messages.h"
 #include "remoting/host/desktop_session_win.h"
@@ skipping 80 matching lines @@
   }
 }
 
 bool DaemonProcessWin::OnDesktopSessionAgentAttached(
     int terminal_id,
     base::ProcessHandle desktop_process,
     IPC::PlatformFileForTransit desktop_pipe) {
   // Prepare |desktop_process| handle for sending over to the network process.
   // |desktop_pipe| is a handle in the desktop process. It will be duplicated
   // by the network process directly from the desktop process.
-  IPC::PlatformFileForTransit desktop_process_for_transit =
+  base::ProcessHandle desktop_process_for_transit =

[Sergey Ulanov, 2013/02/04 21:04:41]

Why do you need this change?

[alexeypa (please no reviews), 2013/02/04 23:45:58]

This is caused by changing DesktopSessionProxy::AttachToDesktop()'s parameter
from IPC::PlatformFileForTransit to base::ProcessHandle. This way I don't need
to add more #if defined(OS_WIN) in all places where |desktop_process| handle is
passed. It also allows me to use process utility functions on the handle without
additional #ifdefs.

I changed this code to call DuplicateHandle() to make it more apparent what is
going on here. This is a Windows-only source so it is safe.

       IPC::GetFileHandleForProcess(desktop_process, network_process_, false);
   if (desktop_process_for_transit == IPC::InvalidPlatformFileForTransit()) {
     LOG(ERROR) << "Failed to duplicate the desktop process handle";
     return false;
   }
 
   SendToNetwork(new ChromotingDaemonNetworkMsg_DesktopAttached(
       terminal_id, desktop_process_for_transit, desktop_pipe));
   return true;
 }
@@ skipping 37 matching lines @@
     scoped_refptr<AutoThreadTaskRunner> io_task_runner,
     const base::Closure& stopped_callback) {
   scoped_ptr<DaemonProcessWin> daemon_process(
       new DaemonProcessWin(caller_task_runner, io_task_runner,
                            stopped_callback));
   daemon_process->Initialize();
   return daemon_process.PassAs<DaemonProcess>();
 }
 
 }  // namespace remoting