Issue 12096063: Fix failing test on Mac 10.6: TestInstallThemeInFullScreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12096063: Fix failing test on Mac 10.6: TestInstallThemeInFullScreen (Closed)

Created:
7 years, 10 months ago by scheib

Modified:
7 years, 10 months ago

Reviewers:

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix failing test on Mac 10.6: TestInstallThemeInFullScreen The initial change in r179554 [1] presumed that IDC_FULLSCREEN would only be issued on Mac 10.7 and later. TestInstallThemeInFullScreen calls fullscreen without a platform & os version check. This solution is to tolerate IDC_FULLSCREEN and convert it to a IDC_PRESENTATION_MODE on Mac 10.6 and earlier. Both are conceptually the same "fullscreen with no browser chrome". [1] http://src.chromium.org/viewvc/chrome?view=rev&revision=179554 BUG=169138 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179747

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/ui/browser_command_controller.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/12096063/1002

7 years, 10 months ago (2013-01-30 21:05:44 UTC) #1

Message was sent while issue was closed.

Change committed as 179747

Expand Messages | Collapse Messages