Fix components_unittests build on TSAN(win)

Fix components_unittests build on TSAN(win)


BUG=172039
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179623

[Jói, 2013-01-29 21:36:44]

LGTM!

On Tue, Jan 29, 2013 at 9:22 PM,  <kaiwang@chromium.org> wrote:
> Reviewers: Jói, Timur Iskhodzhanov,
>
> Description:
> Fix components_unittests build on TSAN(win)
>
>
> BUG=172039
>
>
> Please review this at https://codereview.chromium.org/12096048/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M build/all.gyp
>   M components/components_tests.gypi
>
>
> Index: build/all.gyp
> diff --git a/build/all.gyp b/build/all.gyp
> index
>
8282f7faf92f4c254ee862925d73acd308b434a2..026942346ad99ded4a8e7433b4f89b1586c3476b
> 100644
> --- a/build/all.gyp
> +++ b/build/all.gyp
> @@ -584,6 +584,7 @@
>            'dependencies': [
>              '../base/base.gyp:base_unittests',
>              '../cloud_print/cloud_print.gyp:cloud_print_unittests',
> +            '../components/components.gyp:components_unittests',
>              '../content/content.gyp:content_unittests',
>              '../crypto/crypto.gyp:crypto_unittests',
>              '../ipc/ipc.gyp:ipc_tests',
> Index: components/components_tests.gypi
> diff --git a/components/components_tests.gypi
> b/components/components_tests.gypi
> index
>
c7cde206b18206589ac3880ed0f9880e431d3626..422f7f04b946016855c7d4fdacd7fd1f520dfb04
> 100644
> --- a/components/components_tests.gypi
> +++ b/components/components_tests.gypi
> @@ -42,6 +42,11 @@
>
> '../testing/android/native_test.gyp:native_test_native_code',
>                ]
>              }],
> +            ['OS=="win" and win_use_allocator_shim==1', {
> +              'dependencies': [
> +                '../base/allocator/allocator.gyp:allocator',
> +              ],
> +            }],
>            ],
>          }
>        ],
>
>

[commit-bot: I haz the power, 2013-01-30 01:35:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12096048/1002

[Timur Iskhodzhanov, 2013-01-30 10:02:34]

LGTM.
We don't seem to run components_unittests under TSan on Win at all - should we?
Is it a big target?

[Jói, 2013-01-30 10:26:26]

It's very small, and initially it will contain tests that are being
moved from other targets (primarily the unit_tests target) to the
components_unittests target.  I think we should run it under TSan if
possible.

Cheers,
Jói


On Wed, Jan 30, 2013 at 10:02 AM,  <timurrrr@chromium.org> wrote:
> LGTM.
> We don't seem to run components_unittests under TSan on Win at all - should
> we?
> Is it a big target?
>
> https://chromiumcodereview.appspot.com/12096048/

[commit-bot: I haz the power, 2013-01-30 12:46:59]

Change committed as 179623

[Timur Iskhodzhanov, 2013-01-30 12:55:20]

OK, https://code.google.com/p/chromium/issues/detail?id=173098

2013/1/30 Jói Sigurðsson <joi@chromium.org>:
> It's very small, and initially it will contain tests that are being
> moved from other targets (primarily the unit_tests target) to the
> components_unittests target.  I think we should run it under TSan if
> possible.
>
> Cheers,
> Jói
>
>
> On Wed, Jan 30, 2013 at 10:02 AM,  <timurrrr@chromium.org> wrote:
>> LGTM.
>> We don't seem to run components_unittests under TSan on Win at all - should
>> we?
>> Is it a big target?
>>
>> https://chromiumcodereview.appspot.com/12096048/



-- 
Timur Iskhodzhanov,
Google Russia

[Jói, 2013-01-30 12:56:23]

Awesome, thanks Timur.

On Wed, Jan 30, 2013 at 12:54 PM, Timur Iskhodzhanov
<timurrrr@chromium.org> wrote:
> OK, https://code.google.com/p/chromium/issues/detail?id=173098
>
> 2013/1/30 Jói Sigurðsson <joi@chromium.org>:
>> It's very small, and initially it will contain tests that are being
>> moved from other targets (primarily the unit_tests target) to the
>> components_unittests target.  I think we should run it under TSan if
>> possible.
>>
>> Cheers,
>> Jói
>>
>>
>> On Wed, Jan 30, 2013 at 10:02 AM,  <timurrrr@chromium.org> wrote:
>>> LGTM.
>>> We don't seem to run components_unittests under TSan on Win at all - should
>>> we?
>>> Is it a big target?
>>>
>>> https://chromiumcodereview.appspot.com/12096048/
>
>
>
> --
> Timur Iskhodzhanov,
> Google Russia