Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Issue 12096036: ARM: Rename Simulator::vfp_register to vfp_registers_ (Closed)

Created:
7 years, 10 months ago by hans
Modified:
7 years, 10 months ago
Reviewers:
ulan_google, ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM: Rename Simulator::vfp_register to vfp_registers_ This matches Simulator::registers_ and is in line with the style guide. BUG=none Committed: https://code.google.com/p/v8/source/detail?r=13547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M src/arm/simulator-arm.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/simulator-arm.cc View 10 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
Hi Ulan, I thought I'd fix some of the TODOs from my last patch.
7 years, 10 months ago (2013-01-29 10:46:05 UTC) #1
ulan_google
LGTM, I'll land it for you.
7 years, 10 months ago (2013-01-29 11:22:05 UTC) #2
ulan
lgtm
7 years, 10 months ago (2013-01-30 09:49:51 UTC) #3
ulan
7 years, 10 months ago (2013-01-30 09:50:30 UTC) #4
Message was sent while issue was closed.
Committed manually as r13547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698