Issue 12096018: Add --keep_data as option to adb_install_apk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12096018: Add --keep_data as option to adb_install_apk (Closed)

Created:
7 years, 10 months ago by nduca

Modified:
7 years, 10 months ago

Reviewers:
craigdh, Isaac (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org, Isaac (away)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add --keep_data as option to adb_install_apk Useful in a compile/debug/retry workflow where you're wanting to keep some options persisted across installs. Defaults to off so it doesn't mess anything in production. R=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179275

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	build/android/adb_install_apk.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	build/android/pylib/utils/test_options_parser.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

This lgtm, but let's wait for craig as a double check.

7 years, 10 months ago (2013-01-28 10:18:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/12096018/1

7 years, 10 months ago (2013-01-28 20:29:41 UTC) #4

Message was sent while issue was closed.

Change committed as 179275

Expand Messages | Collapse Messages