Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12095076: Correct the calling convention for the libusb callback. (Closed)

Created:
7 years, 10 months ago by juanlang
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Correct the calling convention for the libusb callback. BUG=173484 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/usb/usb_device.cc View 5 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
juanlang
Hey Garret, this fixes a crash whenever using libusb on Windows. https://memegen.googleplex.com/15110638
7 years, 10 months ago (2013-01-31 01:46:05 UTC) #1
Marius
lgtm
7 years, 10 months ago (2013-01-31 22:26:53 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 10 months ago (2013-01-31 22:40:16 UTC) #3
meacer
+bryeung for OWNERS review.
7 years, 10 months ago (2013-02-01 17:57:35 UTC) #4
Garret Kelly
LGTM
7 years, 10 months ago (2013-02-01 18:13:40 UTC) #5
bryeung
Garret's review is good for OWNERS.
7 years, 10 months ago (2013-02-01 18:14:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juanlang@google.com/12095076/1
7 years, 10 months ago (2013-02-01 19:03:09 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=106592
7 years, 10 months ago (2013-02-02 01:27:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juanlang@google.com/12095076/1
7 years, 10 months ago (2013-02-02 22:51:31 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=107244
7 years, 10 months ago (2013-02-03 01:43:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/juanlang@google.com/12095076/1
7 years, 10 months ago (2013-02-04 01:49:19 UTC) #11
commit-bot: I haz the power
Change committed as 180339
7 years, 10 months ago (2013-02-04 03:23:25 UTC) #12
Marius
7 years, 10 months ago (2013-02-05 02:30:24 UTC) #13
Message was sent while issue was closed. 
On 2013/02/04 03:23:25, I haz the power (commit-bot) wrote:
> Change committed as 180339

Excellent.
Can someone w/ powers on this thread actually push the merge? Plz?

Powered by Google App Engine
This is Rietveld 408576698