Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm

Issue 12095074: Media Galleries: Keep media gallery permission dialogs in sync with the gallery (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix nit Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm
===================================================================
--- chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm (revision 181443)
+++ chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_unittest.mm (working copy)
@@ -129,4 +129,32 @@
EXPECT_EQ(new_container_height, old_container_height);
}
+TEST_F(MediaGalleriesDialogTest, ForgetDeletes) {
+ NiceMock<MediaGalleriesDialogControllerMock> controller;
+
+ MediaGalleriesDialogController::KnownGalleryPermissions permissions;
+ EXPECT_CALL(controller, permissions()).
+ WillRepeatedly(ReturnRef(permissions));
+
+ scoped_ptr<MediaGalleriesDialogCocoa> dialog(
+ static_cast<MediaGalleriesDialogCocoa*>(
+ MediaGalleriesDialog::Create(&controller)));
+
+ // Add a couple of galleries.
+ MediaGalleryPrefInfo gallery1 = MakePrefInfoForTesting(1);
+ dialog->UpdateGallery(&gallery1, true);
+ MediaGalleryPrefInfo gallery2 = MakePrefInfoForTesting(2);
+ dialog->UpdateGallery(&gallery2, true);
+ EXPECT_EQ(2U, [dialog->checkboxes_ count]);
+ CGFloat old_container_height = NSHeight([dialog->checkbox_container_ frame]);
+
+ // Remove a gallery.
+ dialog->ForgetGallery(&gallery1);
+ EXPECT_EQ(1U, [dialog->checkboxes_ count]);
+
+ // The checkbox container should be shorter.
+ CGFloat new_container_height = NSHeight([dialog->checkbox_container_ frame]);
+ EXPECT_LT(new_container_height, old_container_height);
+}
+
} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698