Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12095046: gyp: do not force stack protector on Chrome OS (Closed)

Created:
7 years, 10 months ago by keescook
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

gyp: do not force stack protector on Chrome OS The Chrome OS builds already use -fstack-protector-strong. Adding additional -fstack-protector arguments means that the last one seen on the commandline is used. This has caused a regression in the stack-protector features, so avoid stack-protector on Chrome OS. BUG=chromium-os:38354 TEST=link build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180088

Patch Set 1 #

Total comments: 4

Patch Set 2 : moar comments #

Total comments: 2

Patch Set 3 : fix up comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M build/common.gypi View 1 2 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Jorge Lucangeli Obes
https://codereview.chromium.org/12095046/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12095046/diff/1/build/common.gypi#newcode2381 build/common.gypi:2381: ['os_posix==1 and chromeos!=1', { chromeos==0 seems to be the ...
7 years, 10 months ago (2013-01-29 23:45:51 UTC) #1
keescook
https://codereview.chromium.org/12095046/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12095046/diff/1/build/common.gypi#newcode2381 build/common.gypi:2381: ['os_posix==1 and chromeos!=1', { On 2013/01/29 23:45:51, Jorge Lucangeli ...
7 years, 10 months ago (2013-01-29 23:50:17 UTC) #2
Jorge Lucangeli Obes
lgtm
7 years, 10 months ago (2013-01-29 23:53:02 UTC) #3
Paweł Hajdan Jr.
LGTM with a comment. https://codereview.chromium.org/12095046/diff/3001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12095046/diff/3001/build/common.gypi#newcode2385 build/common.gypi:2385: # TODO(phajdan.jr): Auto-detect use of ...
7 years, 10 months ago (2013-01-30 08:47:21 UTC) #4
keescook
https://codereview.chromium.org/12095046/diff/3001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/12095046/diff/3001/build/common.gypi#newcode2385 build/common.gypi:2385: # TODO(phajdan.jr): Auto-detect use of -fstack-protector-strong instead On 2013/01/30 ...
7 years, 10 months ago (2013-01-30 18:10:44 UTC) #5
Paweł Hajdan Jr.
LGTM just in case.
7 years, 10 months ago (2013-01-31 09:16:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keescook@google.com/12095046/1002
7 years, 10 months ago (2013-01-31 22:12:02 UTC) #7
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
7 years, 10 months ago (2013-01-31 22:12:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keescook@google.com/12095046/1002
7 years, 10 months ago (2013-01-31 22:15:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keescook@google.com/12095046/1002
7 years, 10 months ago (2013-01-31 22:17:20 UTC) #10
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 05:47:18 UTC) #11
Message was sent while issue was closed. 
Change committed as 180088

Powered by Google App Engine
This is Rietveld 408576698