Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 12095005: Use DialogFrameView for ConstrainedWindowViews with --enable-new-dialog-style. (Closed)

Created:
7 years, 11 months ago by msw
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Use DialogFrameView for ConstrainedWindowViews with --enable-new-dialog-style. BUG=166075 TEST=Views constrained windows use the new dialog style with --enable-new-dialog-style. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/views/constrained_window_views.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 11 months ago (2013-01-27 04:07:23 UTC) #1
sky
LGTM
7 years, 10 months ago (2013-01-28 16:10:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12095005/1
7 years, 10 months ago (2013-01-28 16:41:29 UTC) #3
commit-bot: I haz the power
7 years, 10 months ago (2013-01-28 18:00:27 UTC) #4
Message was sent while issue was closed.
Change committed as 179161

Powered by Google App Engine
This is Rietveld 408576698