Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 12094111: chromite_wrapper: Add support for gclient checkouts. (Closed)

Created:
7 years, 10 months ago by rcui1
Modified:
7 years, 10 months ago
Reviewers:
davidjames, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

chromite_wrapper: Add support for gclient checkouts. Chromite will be added to the Chrome checkout at third_party/chromite - detect when the checkout is a gclient checkout, and look for chromite at that path. BUG=None TEST=ran 'cbuildbot' in both a repo and gclient checkout. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=181563

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M support/chromite_wrapper View 1 3 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rcui1
ping...
7 years, 10 months ago (2013-02-06 02:13:26 UTC) #1
M-A Ruel
On 2013/02/06 02:13:26, rcui1 wrote: > ping... You had forgot to send an initial request. ...
7 years, 10 months ago (2013-02-06 19:36:26 UTC) #2
davidjames
lgtm https://codereview.chromium.org/12094111/diff/1/support/chromite_wrapper File support/chromite_wrapper (right): https://codereview.chromium.org/12094111/diff/1/support/chromite_wrapper#newcode38 support/chromite_wrapper:38: '.repo': 'chromite/.git', Should these be in a list ...
7 years, 10 months ago (2013-02-07 00:40:41 UTC) #3
M-A Ruel
rubberstamp lgtm, sorry for the delay.
7 years, 10 months ago (2013-02-07 14:17:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rcui@google.com/12094111/6001
7 years, 10 months ago (2013-02-08 22:27:36 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-08 22:29:57 UTC) #6
Message was sent while issue was closed.
Change committed as 181563

Powered by Google App Engine
This is Rietveld 408576698