Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chrome/browser/net/chrome_net_log.cc

Issue 12094085: LoadTiming in net part 7: Hooking it all up (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/chrome_net_log.h ('k') | chrome/browser/net/load_timing_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/chrome_net_log.cc
===================================================================
--- chrome/browser/net/chrome_net_log.cc (revision 190428)
+++ chrome/browser/net/chrome_net_log.cc (working copy)
@@ -5,11 +5,11 @@
#include "chrome/browser/net/chrome_net_log.h"
#include "base/command_line.h"
+#include "base/file_util.h"
#include "base/logging.h"
#include "base/string_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/values.h"
-#include "chrome/browser/net/load_timing_observer.h"
#include "chrome/browser/net/net_log_logger.h"
#include "chrome/browser/net/net_log_temp_file.h"
#include "chrome/common/chrome_switches.h"
@@ -18,7 +18,6 @@
: last_id_(0),
base_log_level_(LOG_BASIC),
effective_log_level_(LOG_BASIC),
- load_timing_observer_(new LoadTimingObserver()),
net_log_temp_file_(new NetLogTempFile(this)) {
const CommandLine* command_line = CommandLine::ForCurrentProcess();
// Adjust base log level based on command line switch, if present.
@@ -35,8 +34,6 @@
}
}
- load_timing_observer_->StartObserving(this);
-
if (command_line->HasSwitch(switches::kLogNetLog)) {
net_log_logger_.reset(new NetLogLogger(
command_line->GetSwitchValuePath(switches::kLogNetLog)));
@@ -47,8 +44,7 @@
ChromeNetLog::~ChromeNetLog() {
net_log_temp_file_.reset();
// Remove the observers we own before we're destroyed.
- RemoveThreadSafeObserver(load_timing_observer_.get());
- if (net_log_logger_.get())
+ if (net_log_logger_)
RemoveThreadSafeObserver(net_log_logger_.get());
}
« no previous file with comments | « chrome/browser/net/chrome_net_log.h ('k') | chrome/browser/net/load_timing_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698