Issue 12094082: Merge KeyedLoad and NamedLoad stub compiler code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12094082: Merge KeyedLoad and NamedLoad stub compiler code. (Closed)

Created:
7 years, 10 months ago by Toon Verwaest

Modified:
7 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Merge KeyedLoad and NamedLoad stub compiler code. Committed: https://code.google.com/p/v8/source/detail?r=13579

Patch Set 3 : Port to arm and x64. #

Total comments: 1

Patch Set 4 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -655 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 2	5 chunks	+16 lines, -176 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 2	5 chunks	+16 lines, -203 lines	0 comments	Download
M	src/stub-cache.h	View	1 2 3	9 chunks	+84 lines, -66 lines	0 comments	Download
M	src/stub-cache.cc	View		11 chunks	+98 lines, -13 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2	5 chunks	+16 lines, -197 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Look! I found a nit! LGTM otherwise :-) https://chromiumcodereview.appspot.com/12094082/diff/13001/src/stub-cache.h File src/stub-cache.h (right): https://chromiumcodereview.appspot.com/12094082/diff/13001/src/stub-cache.h#newcode608 src/stub-cache.h:608: : ...

7 years, 10 months ago (2013-02-01 12:00:12 UTC) #2

Addressed nit.